From: Greg KH <greg@kroah.com>
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Dave Jones <davej@codemonkey.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Summit support for 2.5 [0/4]
Date: Sun, 13 Oct 2002 19:25:15 -0700 [thread overview]
Message-ID: <20021014022515.GB1768@kroah.com> (raw)
In-Reply-To: <1924305625.1034535736@[10.10.2.3]>
On Sun, Oct 13, 2002 at 07:02:18PM -0700, Martin J. Bligh wrote:
>
> PS. This distros want Summit to autodetect for their install kernels,
> which is what the x86_summit switch is for.
Why? Can't summit boot just fine on a i386 UP kernel? Then they can
look at the chipset id and determine that they should install a
summit-built kernel, right?
> diff -urpN -X /home/fletch/.diff.exclude virgin/arch/i386/Config.help subarch-1/arch/i386/Config.help
> --- virgin/arch/i386/Config.help Fri Oct 11 21:21:31 2002
> +++ subarch-1/arch/i386/Config.help Sun Oct 13 18:40:30 2002
> @@ -73,6 +73,12 @@ CONFIG_X86_CYCLONE
> If you are suffering from time skew using a multi-CEC system, say YES.
> Otherwise it is safe to say NO.
>
> +CONFIG_X86_SUMMIT
Can this just be CONFIG_SUMMIT? I think most of these fixes need to be
around for the ia64 version too :(
> /home/fletch/.diff.exclude virgin/arch/i386/Makefile subarch-1/arch/i386/Makefile
> --- virgin/arch/i386/Makefile Fri Oct 11 21:21:39 2002
> +++ subarch-1/arch/i386/Makefile Sun Oct 13 17:54:32 2002
> @@ -46,7 +46,11 @@ CFLAGS += $(cflags-y)
> ifdef CONFIG_VISWS
> MACHINE := mach-visws
> else
> -MACHINE := mach-generic
> + ifdef CONFIG_X86_SUMMIT
> + MACHINE := mach-summit
> + else
> + MACHINE := mach-generic
> + endif
> endif
As we're going to end up with a mess of a ifdef nest over time with new
archs added, how about something like this (completly untested):
--- 1.12/arch/i386/Makefile Fri Oct 11 14:22:55 2002
+++ edited/Makefile Sun Oct 13 19:26:18 2002
@@ -43,10 +43,14 @@
CFLAGS += $(cflags-y)
-ifdef CONFIG_VISWS
-MACHINE := mach-visws
-else
-MACHINE := mach-generic
+MACHINE = mach-generic
+
+ifeq ($(CONFIG_VISWS),y)
+MACHINE = mach-visws
+endif
+
+ifeq ($(CONFIG_SUMMIT),y)
+MACHINE = mach-summit
endif
HEAD := arch/i386/kernel/head.o arch/i386/kernel/init_task.o
Can make handle reassigning a variable?
Other than that, looks like a good start to me (oh your email client is
wrapping lines of the patch...)
thanks,
greg k-h
next prev parent reply other threads:[~2002-10-14 2:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-13 20:41 Martin J. Bligh
2002-10-13 20:59 ` Greg KH
2002-10-13 21:06 ` Martin J. Bligh
2002-10-13 21:17 ` Greg KH
2002-10-13 21:31 ` Dave Jones
2002-10-13 22:15 ` Linus Torvalds
2002-10-14 2:02 ` Martin J. Bligh
2002-10-14 2:25 ` Greg KH [this message]
2002-10-14 2:49 ` Kai Germaschewski
2002-10-14 3:02 ` Greg KH
2002-10-14 5:46 ` Eric W. Biederman
2002-10-14 3:09 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021014022515.GB1768@kroah.com \
--to=greg@kroah.com \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®