From: Joel Becker <Joel.Becker@oracle.com>
To: Jens Axboe <axboe@suse.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
"Stephen C. Tweedie" <sct@redhat.com>
Subject: Re: [PATCH] superbh, fractured blocks, and grouped io
Date: Mon, 14 Oct 2002 11:13:38 -0700 [thread overview]
Message-ID: <20021014181338.GF22117@nic1-pc.us.oracle.com> (raw)
In-Reply-To: <20021014135100.GD28283@suse.de>
On Mon, Oct 14, 2002 at 03:51:00PM +0200, Jens Axboe wrote:
Just a couple niggles, really. Looking good.
> /*
> - * First step, 'identity mapping' - RAID or LVM might
> - * further remap this.
> + * detach each bh and resubmit, or completely and if its a grouped bh
> */
The last line of the comment means "completely fail if its
grouped", right?
> +#define MAX_SUPERBH 65535 /* must fit info ->b_size right now */
Why not sizeof(b_size) in case we ever care?
> +extern int submit_bh_linked(int, struct buffer_head *);
> +extern int submit_bh_grouped(int, struct buffer_head *);
Why aren't these EXPORT_SYMBOL(), given that a third party
driver may wish to use them (eg, a filesystem doing its own O_DIRECT
work)?
Joel
--
"We'd better get back, `cause it'll be dark soon,
and they mostly come at night. Mostly."
Joel Becker
Senior Member of Technical Staff
Oracle Corporation
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2002-10-14 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-14 13:51 Jens Axboe
2002-10-14 18:13 ` Joel Becker [this message]
2002-10-15 7:44 ` Jens Axboe
2002-10-15 19:33 ` Joel Becker
2002-10-17 0:51 ` Joel Becker
2002-10-17 1:07 ` Joel Becker
2002-10-17 6:03 ` Jens Axboe
2002-10-17 5:59 ` Jens Axboe
2002-10-17 6:45 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021014181338.GF22117@nic1-pc.us.oracle.com \
--to=joel.becker@oracle.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®