mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arndb@de.ibm.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>, kai@tp1.ruhr-uni-bochum.de
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: s390x build warnings from <linux/module.h>
Date: Tue, 15 Oct 2002 19:36:34 +0200	[thread overview]
Message-ID: <200210151936.34119.arndb@de.ibm.com> (raw)

Hi,

during 'make modules' on s390x, I see lots of warnings about 'ignoring 
changed section attributes for __ksymtab' that I have found to be the 
result of changeset 1.373.196.1, where Kai changed the defaults for module 
exports to 'no symbols exported'.

The problem is that there is a section '__ksymtab,"a"', while s390x 
requires it to be '__ksymtab,"aw"' because modules must be compiled with
'-fpic' here, unlike afaics all the other architectures.

The patch below is a workaround for the Problem and should be
correct on all architectures, but I'd prefer if there was a nicer
way to do that.

	Arnd <><

--- broken/include/linux/module.h      15 Oct 2002 07:55:01 -0000      1.8
+++ ugly/include/linux/module.h      15 Oct 2002 15:30:39 -0000
@@ -498,5 +498,9 @@
  * "export all symbols" to modutils)
  */
+#ifndef __PIC__
 __asm__(".section __ksymtab,\"a\"\n.previous");
+#else
+__asm__(".section __ksymtab,\"aw\"\n.previous");
+#endif
 #endif
 

             reply	other threads:[~2002-10-15 15:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-15 17:36 Arnd Bergmann [this message]
2002-10-15 15:59 ` Kai Germaschewski
  -- strict thread matches above, loose matches on Subject: below --
2002-10-15 20:46 Ulrich Weigand
2002-10-15 16:50 Martin Schwidefsky
2002-10-15 18:19 ` Jakub Jelinek
2002-10-15 18:28 ` Kai Germaschewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200210151936.34119.arndb@de.ibm.com \
    --to=arndb@de.ibm.com \
    --cc=arnd@bergmann-dalldorf.de \
    --cc=kai@tp1.ruhr-uni-bochum.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®