From: "Adam J. Richter" <adam@yggdrasil.com>
To: jgarzik@pobox.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][TRIVIAL] de2104x.c missing __devexit_p in 2.5.43
Date: Thu, 17 Oct 2002 10:14:03 -0700 [thread overview]
Message-ID: <200210171714.KAA02527@baldur.yggdrasil.com> (raw)
Jeff Garzik wrote:
>Andrey Panin wrote:
>> diff -urN -X /usr/share/dontdiff linux-vanilla/drivers/net/tulip/de2104x.c \
>> linux/drivers/net/tulip/de2104x.c
>> --- linux-vanilla/drivers/net/tulip/de2104x.c Sun Sep 1 02:04:53 2002
>> +++ linux/drivers/net/tulip/de2104x.c Thu Oct 17 04:10:19 2002
>> @@ -2216,7 +2216,7 @@
>> .name = DRV_NAME,
>> .id_table = de_pci_tbl,
>> .probe = de_init_one,
>> - .remove = de_remove_one,
>> + .remove = __devexit_p(de_remove_one),
>> #ifdef CONFIG_PM
>> .suspend = de_suspend,
>> .resume = de_resume,
>
>
>alas, it is incorrect, as no one hotplugs this hardware.
I believe that there are motherboards that use a chipset from
Compaq that allows hot plugging and unplugging of ordinary PCI cards,
supported by drivers in linux-2.5.43/drivers/hotplug/cpq*.[ch]. At a
trade show, I saw a demo of a motherboard with such a capability (not
running Linux, but I think from Compaq).
So, I believe that all ordinary PCI cards (as opposed to
devices soldered onto motherboards, for example) are now hot plug
capable, although their Linux drivers may not yet be.
Do I misunderstand the situation?
As a side note, I also either do not agree or somehow
misunderstand Jeff Garzik's opposition to devexit_p in non-hotplug
drivers, but that issue will irrelevant in the case of de2104.c if it
is indeed possible for all ordinary PCI form factor cards to be
deployed with the hot plug motherboard chipset that I described.
Adam J. Richter __ ______________ 575 Oroville Road
adam@yggdrasil.com \ / Milpitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."
next reply other threads:[~2002-10-17 17:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-17 17:14 Adam J. Richter [this message]
2002-10-17 17:20 ` Jeff Garzik
2002-10-18 19:41 ` Bill Davidsen
-- strict thread matches above, loose matches on Subject: below --
2002-10-17 7:03 Andrey Panin
2002-10-17 14:21 ` Jeff Garzik
2002-10-18 5:46 ` Andrey Panin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200210171714.KAA02527@baldur.yggdrasil.com \
--to=adam@yggdrasil.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®