From: Daniel Jacobowitz <dan@debian.org>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: PATCH: fix task state reporting
Date: Thu, 17 Oct 2002 17:02:21 -0400 [thread overview]
Message-ID: <20021017210221.GA18872@nevyn.them.org> (raw)
In-Reply-To: <20021017213812.D3326@flint.arm.linux.org.uk>
On Thu, Oct 17, 2002 at 09:38:12PM +0100, Russell King wrote:
> Hi,
>
> While running a test here, I noticed that some threads kept entering
> "T" state according to ps aux. However, rather than stop, they'd
> disappear on the next process listing, as though they weren't stopped.
>
> Further investigation revealed the following when suspending processes:
>
> root 1497 3.8 1.7 1472 544 ttyp1 Z 00:05 0:21 find / -name pro
>
> Yes, 'Z' for suspended, 'T' for zombie. Something smells fishy here.
>
> #define TASK_RUNNING 0
> #define TASK_INTERRUPTIBLE 1
> #define TASK_UNINTERRUPTIBLE 2
> #define TASK_STOPPED 4
> #define TASK_ZOMBIE 8
> #define TASK_DEAD 16
>
> So that's R S D T Z W, but sched.c contains R S D Z T W (Z and T
> reversed). This patch corrects sched.c. (Should we correct
> the order of bits in sched.h instead?)
fs/proc/array.c needs the same fix. I sent this to Ingo but he must
have lost my mail....
===== fs/proc/array.c 1.30 vs edited =====
--- 1.30/fs/proc/array.c Mon Sep 30 05:06:43 2002
+++ edited/fs/proc/array.c Tue Oct 1 13:45:13 2002
@@ -125,9 +125,9 @@
"R (running)", /* 0 */
"S (sleeping)", /* 1 */
"D (disk sleep)", /* 2 */
- "Z (zombie)", /* 4 */
- "T (stopped)", /* 8 */
- "W (paging)" /* 16 */
+ "T (stopped)", /* 4 */
+ "Z (zombie)", /* 8 */
+ "X (dead)" /* 16 */
};
static inline const char * get_task_state(struct task_struct *tsk)
@@ -135,8 +135,9 @@
unsigned int state = tsk->state & (TASK_RUNNING |
TASK_INTERRUPTIBLE |
TASK_UNINTERRUPTIBLE |
+ TASK_STOPPED |
TASK_ZOMBIE |
- TASK_STOPPED);
+ TASK_DEAD);
const char **p = &task_state_array[0];
while (state) {
>
> --- orig/kernel/sched.c Wed Oct 16 09:17:13 2002
> +++ linux/kernel/sched.c Thu Oct 17 21:32:42 2002
> @@ -1798,7 +1798,7 @@
> unsigned long free = 0;
> task_t *relative;
> int state;
> - static const char * stat_nam[] = { "R", "S", "D", "Z", "T", "W" };
> + static const char * stat_nam[] = { "R", "S", "D", "T", "Z", "W" };
>
> printk("%-13.13s ", p->comm);
> state = p->state ? __ffs(p->state) + 1 : 0;
>
> --
> Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
> http://www.arm.linux.org.uk/personal/aboutme.html
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
prev parent reply other threads:[~2002-10-17 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-17 20:38 Russell King
2002-10-17 21:02 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021017210221.GA18872@nevyn.them.org \
--to=dan@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®