mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jeffrey Lim" <kernel-list@jfsworld.fastmail.fm>
To: "David S. Miller" <davem@redhat.com>, genlogic@inrete.it
Cc: linux-kernel@vger.kernel.org
Subject: Re: unhappy with current.h
Date: Fri, 18 Oct 2002 14:49:53 UT	[thread overview]
Message-ID: <20021018144951.337862FD51@server4.fastmail.fm> (raw)


On Mon, 14 Oct 2002 12:52:34 -0700 (PDT), "David S. Miller"
<davem@redhat.com> said:
>
>        From: Daniele Lugli <genlogic@inrete.it>
>        Date: Mon, 14 Oct 2002 21:46:08 +0200
>    
>        Moral of the story: in my opinion kernel developers should reduce to a
>        minimum the use of #define, and preferably use words in uppercase
>        and/or with underscores, in any case not commonly used words.
> 
> Or maybe you should change your datastructure to not have member names
> the conflict with 7 year old well defined global symbols in the Linux
> kernel?
>

I guess tradition may have been well established. Is there an faq for
this somewhere (for these "well defined global symbols", that is) that we
could perhaps refer to?

I do believe he has a point though. It would be good to watch the
#defines in the future, so as to make it easier for aspiring coders.

-jf
 
#!/bin/signoff
# ~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~
echo The reasonable man adapts himself to the world; the unreasonable one
echo persists in trying to adapt the world to himself. Therefore, all
echo progress depends on the unreasonable.
echo                                              — George Bernard Shaw
# ~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~
 
 

             reply	other threads:[~2002-10-18 14:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-18 14:49 Jeffrey Lim [this message]
     [not found] <20021014.161535.17120.336861@webmail4.nyc.untd.com>
2002-10-14 20:24 ` Daniele Lugli
  -- strict thread matches above, loose matches on Subject: below --
2002-10-14 19:46 Daniele Lugli
2002-10-14 19:52 ` David S. Miller
2002-10-14 20:18   ` Daniele Lugli
2002-10-14 20:24 ` Chris Wedgwood
2002-10-15  0:00   ` Rik van Riel
2002-10-15  1:05     ` Chris Wedgwood
2002-10-15  1:12     ` Murray J. Root
2002-10-15 14:11     ` Mikael Pettersson
2002-10-15 20:29       ` Daniele Lugli
2002-10-15 20:44         ` Alexander Viro
2002-10-15 21:01         ` Mikael Pettersson
2002-10-14 20:33 ` Richard B. Johnson
2002-10-14 20:33   ` David S. Miller
2002-10-14 20:37   ` Olivier Galibert
2002-10-15 18:31     ` Richard B. Johnson
2002-10-14 21:22   ` Daniele Lugli
2002-10-15 17:08     ` Richard B. Johnson
2002-10-14 20:45 ` Andi Kleen
2002-10-15  1:09   ` Chris Wedgwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021018144951.337862FD51@server4.fastmail.fm \
    --to=kernel-list@jfsworld.fastmail.fm \
    --cc=davem@redhat.com \
    --cc=genlogic@inrete.it \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®