From: Christoph Hellwig <hch@infradead.org>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use seq_file for /proc/swaps
Date: Tue, 29 Oct 2002 12:13:19 +0000 [thread overview]
Message-ID: <20021029121319.A19590@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.33L2.0210282132000.13581-100000@dragon.pdx.osdl.net>; from rddunlap@osdl.org on Mon, Oct 28, 2002 at 09:36:44PM -0800
On Mon, Oct 28, 2002 at 09:36:44PM -0800, Randy.Dunlap wrote:
>
> Hi,
>
> This patch to 2.5.44 converts /proc/swaps to use seq_file.
>
> It's basically the same patch that I posted a few days ago
> with locking added [using swap_list_lock() and
> swap_list_unlock(), as directed by Al].
>
> Any comments on this version?
Looks fine. Any chance you could move proc_swaps_operations and
the entry creating to swapfile.c so when uclinux makes this file
conditional on CONFIG_SWAP we don't need ifdefs in proc_misc.c?
next prev parent reply other threads:[~2002-10-29 12:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-29 5:36 Randy.Dunlap
2002-10-29 12:13 ` Christoph Hellwig [this message]
2002-10-30 6:12 ` Randy.Dunlap
2002-10-30 16:29 ` Christoph Hellwig
2002-11-05 6:58 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021029121319.A19590@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome