From: Bob Miller <rem@osdl.org>
To: Alexander Viro <viro@math.psu.edu>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.5.45] Export blkdev_ioctl for raw block driver.
Date: Thu, 31 Oct 2002 17:46:22 -0800 [thread overview]
Message-ID: <20021031174622.A1185@doc.pdx.osdl.net> (raw)
In-Reply-To: <20021031172007.A28402@doc.pdx.osdl.net>; from rem@osdl.org on Thu, Oct 31, 2002 at 05:20:07PM -0800
On Thu, Oct 31, 2002 at 05:20:07PM -0800, Bob Miller wrote:
> On Thu, Oct 31, 2002 at 07:11:19PM -0500, Alexander Viro wrote:
Stuff deleted...
> > Why not use ioctl_by_bdev() in the first place? (and yes, it's very likely
> > my fault - I hadn't realized that raw.c went modular at some point).
> Didn't know about ioctl_by_bdev()... I'll make a patch that converts
> the raw driver to call it instead of blkdev_ioctl().
>
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.869 -> 1.870
# drivers/char/raw.c 1.23 -> 1.24
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 02/10/31 rem@doc.pdx.osdl.net 1.870
# Changed raw driver to call ioctl_by_bdev() instead of
# blkdev_ioctl() so that it will build as a module.
# --------------------------------------------
#
diff -Nru a/drivers/char/raw.c b/drivers/char/raw.c
--- a/drivers/char/raw.c Thu Oct 31 17:34:56 2002
+++ b/drivers/char/raw.c Thu Oct 31 17:34:56 2002
@@ -95,7 +95,7 @@
{
struct block_device *bdev = filp->private_data;
- return blkdev_ioctl(bdev->bd_inode, NULL, command, arg);
+ return ioctl_by_bdev(bdev, command, arg);
}
/*
--
Bob Miller Email: rem@osdl.org
Open Source Development Lab Phone: 503.626.2455 Ext. 17
next prev parent reply other threads:[~2002-11-01 0:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-01 0:57 Bob Miller
2002-11-01 0:11 ` Alexander Viro
2002-11-01 1:20 ` Bob Miller
2002-11-01 1:46 ` Bob Miller [this message]
2002-11-01 1:00 ` Alexander Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021031174622.A1185@doc.pdx.osdl.net \
--to=rem@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®