mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: kisza@securityaudit.hu
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com,
	netfilter-devel@lists.netfilter.org, davem@redhat.com,
	kuznet@ms2.inr.ac.ru, usagi@linux-ipv6.org,
	yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] IPv6: Functions Clean-up
Date: Sun, 03 Nov 2002 22:16:58 +0900 (JST)	[thread overview]
Message-ID: <20021103.221658.52523847.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <1036328414.1048.3.camel@arwen>

In article <1036328414.1048.3.camel@arwen> (at Sun, 03 Nov 2002 14:00:14 +0100), Andras Kis-Szabo <kisza@securityaudit.hu> says:

> This patch removes one function from the Netfilter code and forces the
> Netfilter to use a similar function from the kernel's one!

net/ipv6/netfilter/ip6_queue.c says:

/*
 * Taken from net/ipv6/ip6_output.c
 * We should use the one there, but is defined static
 * so we put this just here and let the things as
 * they are now.
 *
 * If that one is modified, this one should be modified too.
 */

So, the reason why the copy of route6_me_harder() 
lives there is because net/ipv6/ip6_output.c has not been 
exported it.

Is this something to do with parser of extension headers?
Parser of extension headers is different thing, isn't it?

Yes, since duplication of code is bad unless there're really 
strong reasons.  I believe that there would be a better 
design for filtering.

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

  parent reply	other threads:[~2002-11-03 13:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-03  2:54 YOSHIFUJI Hideaki / 吉藤英明
2002-11-03 13:00 ` Andras Kis-Szabo
2002-11-03 12:03   ` David S. Miller
2002-11-03 12:08   ` Pekka Savola
2002-11-03 13:16   ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2002-11-03 13:20     ` YOSHIFUJI Hideaki / 吉藤英明
2002-11-03 13:22     ` James Morris
2002-11-03 14:27     ` Andras Kis-Szabo
2003-02-23  9:18 ` David S. Miller
2003-02-24  3:57   ` YOSHIFUJI Hideaki / 吉藤英明
2003-02-24  6:25     ` David S. Miller
2003-02-24  6:54     ` David S. Miller
2003-02-24  7:18       ` YOSHIFUJI Hideaki / 吉藤英明
2003-02-24  7:29         ` YOSHIFUJI Hideaki / 吉藤英明
2003-02-24  7:18           ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021103.221658.52523847.yoshfuji@linux-ipv6.org \
    --to=yoshfuji@linux-ipv6.org \
    --cc=davem@redhat.com \
    --cc=kisza@securityaudit.hu \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=usagi@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®