From: Rusty Russell <rusty@rustcorp.com.au>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Module loader against 2.5.46: 6/9
Date: Tue, 05 Nov 2002 11:36:40 +1100 [thread overview]
Message-ID: <20021105005214.046A22C155@lists.samba.org> (raw)
In-Reply-To: Your message of "Tue, 05 Nov 2002 11:21:48 +1100." <20021105002215.8EEE22C0F8@lists.samba.org>
Trivially remove the #if 0 in module.c to enable the parameter parsing
for modules.
Linus, please apply.
Rusty.
Name: Parameter Implementation for modules
Author: Rusty Russell
Status: Tested on 2.5.38
Depends: Module/param.patch.gz
D: This activates parameter parsing for PARAM() declarations in modules.
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .31807-linux-2.5.43/kernel/module.c .31807-linux-2.5.43.updated/kernel/module.c
--- .31807-linux-2.5.43/kernel/module.c 2002-10-18 17:17:25.000000000 +1000
+++ .31807-linux-2.5.43.updated/kernel/module.c 2002-10-18 17:17:57.000000000 +1000
@@ -25,6 +25,7 @@
#include <linux/fcntl.h>
#include <linux/rcupdate.h>
#include <linux/cpu.h>
+#include <linux/params.h>
#include <asm/uaccess.h>
#include <asm/semaphore.h>
#include <asm/pgalloc.h>
@@ -951,8 +952,7 @@ static struct module *load_module(void *
if (err < 0)
goto cleanup;
-#if 0 /* Needs param support */
- /* Size of section 0 is 0, so this works well */
+ /* Size of section 0 is 0, so this works well if no params */
err = parse_args(mod->args,
(struct kernel_param *)
sechdrs[setupindex].sh_offset,
@@ -961,7 +961,6 @@ static struct module *load_module(void *
NULL);
if (err < 0)
goto cleanup;
-#endif
/* Get rid of temporary copy */
vfree(hdr);
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2002-11-05 0:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-05 0:21 [PATCH] Module loader against 2.5.46: 1/9 Rusty Russell
2002-11-05 0:29 ` [PATCH] Module loader against 2.5.46: 3/9 Rusty Russell
2002-11-05 0:31 ` [PATCH] Module loader against 2.5.46: 4/9 Rusty Russell
2002-11-05 0:35 ` [PATCH] Module loader against 2.5.46: 5/9 Rusty Russell
2002-11-05 0:36 ` Rusty Russell [this message]
2002-11-05 0:41 ` [PATCH] Module loader against 2.5.46: 7/9 Rusty Russell
2002-11-05 0:43 ` [PATCH] Module loader against 2.5.46: 8/9 Rusty Russell
2002-11-05 3:19 ` Werner Almesberger
2002-11-05 3:51 ` Rusty Russell
2002-11-05 4:08 ` Werner Almesberger
2002-11-05 4:24 ` Rusty Russell
2002-11-06 16:45 ` Bill Davidsen
2002-11-07 11:24 ` Rusty Russell
2002-11-08 3:15 ` Randy.Dunlap
2002-11-08 21:15 ` Bill Davidsen
2002-11-09 12:24 ` Mark H. Wood
2002-11-10 3:21 ` Rusty Russell
2002-11-11 12:03 ` Horst von Brand
2002-11-11 12:35 ` Richard B. Johnson
2002-11-05 0:47 ` [PATCH] Module loader against 2.5.46: 9/9 Rusty Russell
2002-11-06 12:43 ` Keith Owens
2002-11-07 11:08 ` Rusty Russell
2002-11-08 9:35 ` Russell King
2002-11-09 3:01 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021105005214.046A22C155@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®