From: "Adam J. Richter" <adam@yggdrasil.com>
To: ink@jurassic.park.msu.ru
Cc: alan@lxorguk.ukuu.org.uk, greg@kroah.com, jgarzik@pobox.com,
jung-ik.lee@intel.com, linux-kernel@vger.kernel.org
Subject: Re: Patch: 2.5.45 PCI Fixups for PCI HotPlug
Date: Tue, 5 Nov 2002 05:17:10 -0800 [thread overview]
Message-ID: <200211051317.FAA26655@adam.yggdrasil.com> (raw)
Ivan Kokshaysky wrote:
>On Mon, Nov 04, 2002 at 12:29:37PM -0800, Adam J. Richter wrote:
>You cannot mark individual quirk routines differently as long as they
>belong in the same quirk list. If the list is __devinitdata and some
>of routines in it are __init, you'll have an oops in the hotplug path.
If pci_do_fixups determines that f->vendor and f->device do
not match the device in question, it will not call the corresponding
f->hook, so it is OK for that f->hook to point to the address of a
discarded __init routine that now contains garbage as long as the
ID's will not match any hot plugged device.
Adam J. Richter __ ______________ 575 Oroville Road
adam@yggdrasil.com \ / Milpitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."
next reply other threads:[~2002-11-05 13:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-05 13:17 Adam J. Richter [this message]
2002-11-05 15:28 ` Ivan Kokshaysky
-- strict thread matches above, loose matches on Subject: below --
2002-11-06 0:14 Adam J. Richter
2002-11-04 20:29 Adam J. Richter
2002-11-04 20:44 ` Jeff Garzik
2002-11-05 13:01 ` Ivan Kokshaysky
2002-11-04 18:23 Adam J. Richter
2002-11-04 19:05 ` Alan Cox
2002-11-04 18:06 Lee, Jung-Ik
2002-11-03 12:31 Adam J. Richter
2002-11-03 0:56 Lee, Jung-Ik
2002-11-03 7:58 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200211051317.FAA26655@adam.yggdrasil.com \
--to=adam@yggdrasil.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jgarzik@pobox.com \
--cc=jung-ik.lee@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®