mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Jens Axboe <axboe@suse.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Arjan van de Ven <arjanv@redhat.com>,
	Jeff Garzik <jgarzik@pobox.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 2.5 vi .config ; make oldconfig not working
Date: Tue, 5 Nov 2002 20:30:04 +0100	[thread overview]
Message-ID: <20021105193004.GA2872@mars.ravnborg.org> (raw)
In-Reply-To: <20021105181431.GB3515@suse.de>

On Tue, Nov 05, 2002 at 07:14:31PM +0100, Jens Axboe wrote:
> I'll write the script, just a damn shame that this feature is gone now.
> .config editing is less powerful now.
The following patch should make most garbage, such as =n, result in
# CONFIG_FOO is not set
without any user confirmation.

Roman - the code uses "//" for comments. Thats not usual kernel style.

	Sam

===== confdata.c 1.1 vs edited =====
--- 1.1/scripts/kconfig/confdata.c	Wed Oct 30 02:16:44 2002
+++ edited/confdata.c	Tue Nov  5 20:25:59 2002
@@ -147,14 +147,28 @@
 			}
 			switch (sym->type) {
 			case S_BOOLEAN:
-				sym->def = symbol_yes.curr;
-				sym->flags &= ~SYMBOL_NEW;
+				if (p[0] == 'y') {
+					sym->def = symbol_yes.curr;
+					sym->flags &= ~SYMBOL_NEW;
+				}
+				else
+				{
+					sym->def = symbol_no.curr;
+					sym->flags &= ~SYMBOL_NEW;
+					continue;
+				}
 				break;
 			case S_TRISTATE:
 				if (p[0] == 'm')
 					sym->def = symbol_mod.curr;
-				else
+				else if (p[0] == 'y')
 					sym->def = symbol_yes.curr;
+				else
+				{
+					sym->def = symbol_no.curr;
+					sym->flags &= ~SYMBOL_NEW;
+					continue;
+				}
 				sym->flags &= ~SYMBOL_NEW;
 				break;
 			case S_STRING:

  reply	other threads:[~2002-11-05 19:24 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-05 16:50 Jens Axboe
2002-11-05 17:08 ` Jeff Garzik
2002-11-05 17:13   ` Dave Jones
2002-11-05 17:16     ` Jens Axboe
2002-11-05 17:21     ` Jeff Garzik
2002-11-05 17:14   ` Jens Axboe
2002-11-05 17:19     ` Jeff Garzik
2002-11-05 17:21       ` Jens Axboe
2002-11-05 18:14         ` Joel Becker
2002-11-05 18:15           ` Jens Axboe
2002-11-06 14:06         ` Roman Zippel
2002-11-06 14:13           ` Jens Axboe
2002-11-05 17:23     ` Randy.Dunlap
2002-11-05 17:26     ` Arjan van de Ven
2002-11-05 17:26       ` Jens Axboe
2002-11-05 17:27         ` Jens Axboe
2002-11-05 18:20         ` Alan Cox
2002-11-05 18:14           ` Jens Axboe
2002-11-05 19:30             ` Sam Ravnborg [this message]
2002-11-05 19:42               ` Petr Baudis
2002-11-05 20:51                 ` Sam Ravnborg
2002-11-05 20:16             ` Peter H. Ruegg
2002-11-05 18:55           ` [PATCH] Allow 'n' as a symbol value in the .config file Petr Baudis
2002-11-05 18:59             ` Jens Axboe
2002-11-06 19:39         ` 2.5 vi .config ; make oldconfig not working Rob Landley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021105193004.GA2872@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=arjanv@redhat.com \
    --cc=axboe@suse.de \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®