mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "J.E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
To: john stultz <johnstul@us.ibm.com>
Cc: "J.E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Linus Torvalds <torvalds@transmeta.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: Voyager subarchitecture for 2.5.46
Date: Wed, 06 Nov 2002 10:03:12 -0500	[thread overview]
Message-ID: <200211061503.gA6F3DW02053@localhost.localdomain> (raw)
In-Reply-To: Message from john stultz <johnstul@us.ibm.com>  of "05 Nov 2002 18:31:04 PST." <1036549864.6098.76.camel@cog>

johnstul@us.ibm.com said:
> I'm fine w/ the X86_TSC change, but I'd drop the X86_PIT for now.  

> Then when you boot, boot w/ notsc and you should be fine. 
> I do want to add some sort of TSC blacklisting so one doesn't always
> have to boot w/ notsc if your machine is detectable/
> compiled-exclusively= for. But I've got a few other issues in the
> queue first.  

There are certain architectures (voyager is the only one currently supported, 
but I suspect the Numa machines will have this too) where the TSC cannot be 
used for cross CPU timings because the processors are driven by separate 
clocks and may even have different clock speeds.

What I need is an option simply not to compile in the TSC code and use the PIT 
instead.  What I'm trying to do with the TSC and PIT options is give three 
choices:

1. Don't use TSC (don't compile TSC code): X86_TSC=n, X86_PIT=y

2. May use TSC but check first (blacklist, notsc kernel option).  X86_TSC=y, 
X86_PIT=y

3. TSC is always OK so don't need PIT.  X86_TSC=y, X86_PIT=n

We probably need to make the notsc and dodgy tsc check contingent on X86_PIT 
(or a config option that says we have some other timer mechanism compiled in). 
 Really, the options should probably be handled in timer.c.

Theres also another problem in that the timer_init is called too early in the 
boot sequence to get a message out to the user, so the panic in timers.c about 
not finding a suitable timer will never be seen (the system will just lock up 
on boot).

Do we have an option for a deferred panic that will trip just after we init 
the console and clean out the printk buffer?

> Then make the arch/i386/timers/Makefile change to be something like:
> 
> obj-y := timer.o timer_tsc.o timer_pit.o
> obj-$(CONFIG_X86_TSC)		-= timer_pit.o #does this(-=) work?
> obj-$(CONFIG_X86_CYCYLONE)	+= timer_cyclone.o

Even if it works, the config option style is confusing.  It's easier just to 
have a positive option (CONFIG_X86_PIT) for this.

James




  parent reply	other threads:[~2002-11-06 14:56 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-05 20:45 J.E.J. Bottomley
2002-11-06  2:31 ` john stultz
2002-11-06 13:43   ` Alan Cox
2002-11-06 21:35     ` john stultz
2002-11-06 15:03   ` J.E.J. Bottomley [this message]
2002-11-06 15:38     ` Alan Cox
2002-11-06 16:09       ` Christer Weinigel
2002-11-06 15:45     ` Linus Torvalds
2002-11-06 16:19       ` Alan Cox
2002-11-06 16:12         ` Linus Torvalds
2002-11-06 16:45           ` Alan Cox
2002-11-10 16:30           ` Pavel Machek
2002-11-10 18:59             ` Linus Torvalds
2002-11-10 19:18               ` Pavel Machek
2002-11-10 19:31                 ` Linus Torvalds
2002-11-10 19:42                   ` Pavel Machek
2002-11-10 19:48                     ` Vojtech Pavlik
2002-11-10 20:02                     ` Sean Neakums
2002-11-10 20:16                       ` Lars Marowsky-Bree
2002-11-10 22:11                         ` Alan Cox
2002-11-10 19:46               ` Vojtech Pavlik
2002-11-11 20:40                 ` john stultz
2002-11-11 20:57                   ` J.E.J. Bottomley
2002-11-11 21:36                     ` William Lee Irwin III
2002-11-11 21:58                     ` john stultz
2002-11-11 22:49                       ` J.E.J. Bottomley
2002-11-11 23:12                         ` john stultz
2002-11-12 12:16                     ` Pavel Machek
2002-11-11 22:08                   ` Vojtech Pavlik
2002-11-06 20:07       ` john stultz
2002-11-06 22:36       ` H. Peter Anvin
2002-11-06 19:30     ` john stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200211061503.gA6F3DW02053@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®