From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@digeo.com>
Cc: vda@port.imtp.ilyichevsk.odessa.ua,
Andreas Dilger <adilger@clusterfs.com>,
linux-kernel@vger.kernel.org,
Marco van Wieringen <mvw@planets.elm.net>
Subject: Re: [PATCH] remove extern inline from quotaops.h
Date: Wed, 6 Nov 2002 18:43:48 +0000 [thread overview]
Message-ID: <20021106184348.A25077@infradead.org> (raw)
In-Reply-To: <3DC95F0A.50DB3C1@digeo.com>; from akpm@digeo.com on Wed, Nov 06, 2002 at 10:27:22AM -0800
On Wed, Nov 06, 2002 at 10:27:22AM -0800, Andrew Morton wrote:
> Denis Vlasenko wrote:
> >
> > For example,
> >
> > static __inline__ int DQUOT_ALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
> > {
> > lock_kernel();
> > if (sb_any_quota_enabled(inode->i_sb)) {
>
> That's nuts.
>
> Here you go. Saves 7k in an ext2+ext3 build, and a lot of it is
> fastpath. This will significantly reduce the cache footprint
> which the kernel presents to applications which are performing
> filesystem operations.
What about giving it non-shouting names while you're at it?
next prev parent reply other threads:[~2002-11-06 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-04 21:13 Andreas Dilger
2002-11-06 20:11 ` Denis Vlasenko
2002-11-06 18:27 ` Andrew Morton
2002-11-06 18:43 ` Christoph Hellwig [this message]
2002-11-06 19:09 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021106184348.A25077@infradead.org \
--to=hch@infradead.org \
--cc=adilger@clusterfs.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mvw@planets.elm.net \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®