From: Greg KH <greg@kroah.com>
To: Adam Belay <ambx1@neo.rr.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pnp.h changes - 2.5.46 (4/6)
Date: Wed, 6 Nov 2002 22:01:02 -0800 [thread overview]
Message-ID: <20021107060102.GB26821@kroah.com> (raw)
In-Reply-To: <20021106210639.GO316@neo.rr.com>
On Wed, Nov 06, 2002 at 09:06:39PM +0000, Adam Belay wrote:
>
> +static inline void *pnp_get_drvdata (struct pnp_dev *pdev)
> +{
> + return pdev->dev.driver_data;
> +}
> +
> +static inline void pnp_set_drvdata (struct pnp_dev *pdev, void *data)
> +{
> + pdev->dev.driver_data = data;
> +}
> +
> +static inline void *pnp_get_protodata (struct pnp_dev *pdev)
> +{
> + return pdev->protocol_data;
> +}
> +
> +static inline void pnp_set_protodata (struct pnp_dev *pdev, void *data)
> +{
> + pdev->protocol_data = data;
> +}
Any reason for not just using dev_get_drvdata() and dev_set_drvdata() in
the drivers? Or at the least, use them within these functions, that's
what they are there for :)
thanks,
greg k-h
next prev parent reply other threads:[~2002-11-07 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-06 21:06 Adam Belay
2002-11-07 6:01 ` Greg KH [this message]
2002-11-07 19:25 ` Adam Belay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021107060102.GB26821@kroah.com \
--to=greg@kroah.com \
--cc=ambx1@neo.rr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®