From: Mike Anderson <andmike@us.ibm.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Russell King <rmk@arm.linux.org.uk>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Rusty Trivial Russell <trivial@rustcorp.com.au>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] SCSI on non-ISA systems
Date: Fri, 8 Nov 2002 16:50:11 -0800 [thread overview]
Message-ID: <20021109005011.GC1040@beaverton.ibm.com> (raw)
In-Reply-To: <1036772421.16651.10.camel@irongate.swansea.linux.org.uk>
Alan Cox [alan@lxorguk.ukuu.org.uk] wrote:
> On Fri, 2002-11-08 at 14:42, Russell King wrote:
> > Probably the correct answer is to get everyone to use an explicit release
> > function and just kill scsi_host_generic_release() entirely.
> >
> > However, I'm sure other people will have differing views on that.
>
> There are three things I'd like to do in that area
>
> 1. Make a release function mandatory (and I'm happy to paste it into the
> old scsi drivers)
This sounds good to get rid of this function. My list of drivers having
detect functions shows only 16 of 103 would need the addition of a
release function.
There is already a check for detect at the top of the scsi_register_host
function. When release is added a printk would also be nice to indicate
lack of these required functions. Douglas Gilbert is starting to work on
updating the api document so we can change the required field to yes if
the driver is using the scsi_register_host / scsi_unregister_host
interface and not-required if it using Christoph's newer scsi_add_host /
scsi_remove_host.
-andmike
--
Michael Anderson
andmike@us.ibm.com
next prev parent reply other threads:[~2002-11-09 0:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-08 13:46 Geert Uytterhoeven
2002-11-08 13:57 ` Russell King
2002-11-08 14:22 ` Geert Uytterhoeven
2002-11-08 14:42 ` Russell King
2002-11-08 16:20 ` Alan Cox
2002-11-09 0:50 ` Mike Anderson [this message]
2002-11-09 0:53 ` Christoph Hellwig
2002-11-09 13:13 ` Alan Cox
2002-11-09 14:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021109005011.GC1040@beaverton.ibm.com \
--to=andmike@us.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®