mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Horst von Brand <vonbrand@inf.utfsm.cl>
To: hps@intermeta.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [2.4.20-rc1] compiler fix drivers/ide/pdc202xx.c
Date: Mon, 11 Nov 2002 12:02:36 -0300	[thread overview]
Message-ID: <200211111502.gABF2ajg031284@pincoya.inf.utfsm.cl> (raw)
In-Reply-To: Message from "Henning P. Schmiedehausen" <hps@intermeta.de>  of "Mon, 11 Nov 2002 11:49:16 -0000." <aqo5fs$65i$1@forge.intermeta.de>

"Henning P. Schmiedehausen" <hps@intermeta.de> said:
> Daniel Mehrmann <daniel.mehrmann@gmx.de> writes:
> 
> >Hello Marcelo,
> 
> >i fix a compiler warning from pdc202xx.c.
> >The "default:" value in the switch was empty. Gcc don`t like
> >this. We don`t need this one. 
> 
> Correct solution is not to remove the "default:" but to add a "break;"

So people start wondering if somehow the content of the default case got
deleted by mistake? Better not. Plus it is needless (source) code bloat.
-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                     Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria              +56 32 654239
Casilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513

  reply	other threads:[~2002-11-11 14:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-10 21:11 Daniel Mehrmann
2002-11-11 11:49 ` Henning P. Schmiedehausen
2002-11-11 15:02   ` Horst von Brand [this message]
2002-11-11 23:14     ` Henning P. Schmiedehausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200211111502.gABF2ajg031284@pincoya.inf.utfsm.cl \
    --to=vonbrand@inf.utfsm.cl \
    --cc=hps@intermeta.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®