mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rick Lindsley <ricklind@us.ibm.com>
To: Per Andreas Buer <perbu@linpro.no>
Cc: linux-kernel@vger.kernel.org
Subject: Re: iostats broken for devices with major number > DK_MAX_DISK (16)
Date: Tue, 12 Nov 2002 15:41:43 -0800	[thread overview]
Message-ID: <200211122341.gACNfhD17153@eng4.beaverton.ibm.com> (raw)
In-Reply-To: Your message of "12 Nov 2002 21:35:38 +0100." <PERBUMSGID-ul64ramh6g5.fsf@nfsd.linpro.no>

    sorry for the intrusion. I noticed iostats didn't display statistics for
    devices on Mylex RAID constrollers. Det statistics are completely
    missing in /proc/stat. The reason seems to be an assumption that disks
    have major numbers which are below 16
    (http://lxr.linux.no/source/include/linux/kernel_stat.h#L15) which is
    used by http://lxr.linux.no/source/fs/proc/proc_misc.c#L344.
    
    Devices on Mylex-controllers have major number 48. Would it break
    anything if DK_MAX_MAJOR if set higher (e.g. 64)?
    
    AFAIK this goes for both 2.4 and the 2.5 series.

Which kernel did you observe it on?

In 2.4, yes, you're right. Without patches, there's a limit.  Patches do
exist that remove those limits though.

In >= 2.5.47, no. They've been completely removed from /proc/stat and
appear in sysfs.  And there are no major device number limits.

For various other flavors of 2.5 and assorted patches, the answer is
"well maybe, kind of"  depending on where you got your 2.5 from and
what patches you may have applied on top of that.

Rick

      parent reply	other threads:[~2002-11-12 23:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-12 20:35 Per Andreas Buer
2002-11-12 23:01 ` James Stevenson
2002-11-12 23:25   ` Cliff White
2002-11-12 23:40     ` James Stevenson
2002-11-12 23:41 ` Rick Lindsley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200211122341.gACNfhD17153@eng4.beaverton.ibm.com \
    --to=ricklind@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perbu@linpro.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®