From: "Adam J. Richter" <adam@yggdrasil.com>
To: ak@suse.de, gzp@myhost.mynet, linux-kernel@vger.kernel.org,
torvalds@transmeta.com
Subject: Re: [PATCH] fix devfs compile problems was Re: Linux v2.5.48
Date: Mon, 18 Nov 2002 16:07:17 -0800 [thread overview]
Message-ID: <200211190007.QAA00499@baldur.yggdrasil.com> (raw)
Hi Linus,
I'd like to recommend that you apply this to fix
fs/devfs/base.c compilation problems instead of Andi's patch, as this
one ensures that {a,m,c}time will all have the same value even if
successive calls to get_seconds() might someday be able to return
different values. Do you concur, Andi?
Adam J. Richter __ ______________ 575 Oroville Road
adam@yggdrasil.com \ / Milpitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."
--- linux-2.5.48/fs/devfs/base.c 2002-11-17 20:29:26.000000000 -0800
+++ linux/fs/devfs/base.c 2002-11-18 16:04:13.000000000 -0800
@@ -3029,9 +3029,7 @@
de->vfs_deletable = TRUE;
de->inode.uid = current->euid;
de->inode.gid = current->egid;
- de->inode.atime = CURRENT_TIME;
- de->inode.mtime = CURRENT_TIME;
- de->inode.ctime = CURRENT_TIME;
+ de->inode.ctime = de->inode.mtime = de->inode.atime = get_seconds();
if ( ( inode = _devfs_get_vfs_inode (dir->i_sb, de, dentry) ) == NULL )
return -ENOMEM;
DPRINTK (DEBUG_DISABLED, "(%s): new VFS inode(%u): %p dentry: %p\n",
@@ -3060,9 +3058,7 @@
return err;
de->inode.uid = current->euid;
de->inode.gid = current->egid;
- de->inode.atime = CURRENT_TIME;
- de->inode.mtime = CURRENT_TIME;
- de->inode.ctime = CURRENT_TIME;
+ de->inode.ctime = de->inode.mtime = de->inode.atime = get_seconds();
if ( ( inode = _devfs_get_vfs_inode (dir->i_sb, de, dentry) ) == NULL )
return -ENOMEM;
DPRINTK (DEBUG_DISABLED, "(%s): new VFS inode(%u): %p dentry: %p\n",
@@ -3129,9 +3125,7 @@
return err;
de->inode.uid = current->euid;
de->inode.gid = current->egid;
- de->inode.atime = CURRENT_TIME;
- de->inode.mtime = CURRENT_TIME;
- de->inode.ctime = CURRENT_TIME;
+ de->inode.ctime = de->inode.mtime = de->inode.atime = get_seconds();
if ( ( inode = _devfs_get_vfs_inode (dir->i_sb, de, dentry) ) == NULL )
return -ENOMEM;
DPRINTK (DEBUG_I_MKNOD, ": new VFS inode(%u): %p dentry: %p\n",
next reply other threads:[~2002-11-19 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-19 0:07 Adam J. Richter [this message]
2002-11-19 0:20 ` Andi Kleen
2002-11-19 1:13 ` Linus Torvalds
[not found] <Pine.LNX.4.44.0211172036590.32717-100000@penguin.transmeta.com.suse.lists.linux.kernel>
[not found] ` <66aa.3dd8ae09.31d44@gzp1.gzp.hu.suse.lists.linux.kernel>
2002-11-18 12:43 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200211190007.QAA00499@baldur.yggdrasil.com \
--to=adam@yggdrasil.com \
--cc=ak@suse.de \
--cc=gzp@myhost.mynet \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®