From: Jens Axboe <axboe@suse.de>
To: Andy Chou <acc@CS.Stanford.EDU>
Cc: mc@cs.stanford.edu, linux-kernel@vger.kernel.org
Subject: Re: [CHECKER] 74 potential buffer overruns in 2.5.33
Date: Wed, 20 Nov 2002 08:50:48 +0100 [thread overview]
Message-ID: <20021120075048.GG11884@suse.de> (raw)
In-Reply-To: <20021119234531.GA2723@Xenon.stanford.edu>
On Tue, Nov 19 2002, Andy Chou wrote:
> Here are 74 out-of-bounds array accesses in Linux 2.5.33 found by the
Ewwww, why so old??
> [BUG] Seems bad.
> /home/acc/linux/2.5.33/drivers/block/ll_rw_blk.c:556:blk_dump_rq_flags:
> ERROR:BUFFER:556:556:Array bounds error: rq_flags[12] indexed with [12]
>
> printk("%s: dev %02x:%02x: ", msg, major(rq->rq_dev),
> minor(rq->rq_dev));
> bit = 0;
> do {
> if (rq->flags & (1 << bit))
>
> Error --->
> printk("%s ", rq_flags[bit]);
> bit++;
> } while (bit < __REQ_NR_BITS);
This was due to someone adding and removing __REQ_* flags and not
changing blk_dump_rq_flags(). 2.5.48 has no such bug anymore, I fixed
this up long ago.
--
Jens Axboe
next prev parent reply other threads:[~2002-11-20 7:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-19 23:45 Andy Chou
2002-11-20 3:00 ` [PATCH] " Rik van Riel
2002-11-20 7:50 ` Jens Axboe [this message]
2002-11-20 8:53 ` Nikita Danilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021120075048.GG11884@suse.de \
--to=axboe@suse.de \
--cc=acc@CS.Stanford.EDU \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@cs.stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®