From: Patrick Mansfield <patmans@us.ibm.com>
To: Christoph Hellwig <hch@lst.de>,
James.Bottomley@steeleye.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove unused includes and misleading comments from scsi_lib.c
Date: Wed, 20 Nov 2002 11:10:16 -0800 [thread overview]
Message-ID: <20021120111016.A20388@eng2.beaverton.ibm.com> (raw)
In-Reply-To: <20021120185048.A4886@lst.de>; from hch@lst.de on Wed, Nov 20, 2002 at 06:50:48PM +0100
On Wed, Nov 20, 2002 at 06:50:48PM +0100, Christoph Hellwig wrote:
> On Wed, Nov 20, 2002 at 08:47:09AM -0800, Patrick Mansfield wrote:
> > I had to add back the smp_lock.h include to compile with CONFIG_PREEMPT,
> > as kernel_locked was not defined and is used by in_atomic().
>
> Bah. Any chance you could fix the header declaring in_atomic() to pull
> in smp_lock.h by itself instead?
It is in hardirq.h, arch specific, 11 of the 20 hardirq.h files would
need the change (they reference kernel_locked) to include smp_lock.h.
665 files include smp_lock.h
89 files include hardirq.h
32 files include both
So, should I change the arch hardirq.h files to include smp_lock.h,
or just add smp_lock.h to scsi_lib.c?
-- Patrick Mansfield
next prev parent reply other threads:[~2002-11-20 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20021117235449.B9824@lst.de>
[not found] ` <20021120084709.A18453@eng2.beaverton.ibm.com>
2002-11-20 17:50 ` Christoph Hellwig
2002-11-20 19:10 ` Patrick Mansfield [this message]
2002-11-20 19:25 ` J.E.J. Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021120111016.A20388@eng2.beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=James.Bottomley@steeleye.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®