From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pcibios removal changes for 2.5.48
Date: Wed, 20 Nov 2002 13:16:29 +0300 [thread overview]
Message-ID: <20021120131629.A21139@jurassic.park.msu.ru> (raw)
In-Reply-To: <20021120051820.GD21953@kroah.com>; from greg@kroah.com on Tue, Nov 19, 2002 at 09:18:20PM -0800
On Tue, Nov 19, 2002 at 09:18:20PM -0800, Greg KH wrote:
> #ifdef CONFIG_CARDBUS
> if (s->state & SOCKET_CARDBUS) {
> u_int ptr;
> - pcibios_read_config_dword(s->cap.cb_dev->subordinate->number, 0, 0x28, &ptr);
> + struct pci_dev *dev = pci_find_slot (s->cap.cb_dev->subordinate->number, 0);
> + if (!dev)
> + return CS_BAD_HANDLE;
> + pci_read_config_dword(dev, 0x28, &ptr);
> tuple->CISOffset = ptr & ~7;
> SPACE(tuple->Flags) = (ptr & 7);
> } else
pci_find_slot seems to be an overkill. Why not just
- pcibios_read_config_dword(s->cap.cb_dev->subordinate->number, 0, 0x28, &ptr);
+ pci_bus_read_config_dword(s->cap.cb_dev->subordinate, 0, 0x28, &ptr);
?
Ivan.
next prev parent reply other threads:[~2002-11-20 10:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-20 5:17 [BK PATCH] " Greg KH
2002-11-20 5:17 ` [PATCH] " Greg KH
2002-11-20 5:18 ` Greg KH
2002-11-20 5:19 ` Greg KH
2002-11-20 10:16 ` Ivan Kokshaysky [this message]
2002-11-26 0:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021120131629.A21139@jurassic.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®