From: Benjamin LaHaise <bcrl@redhat.com>
To: Luben Tuikov <luben@splentec.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, axboe@suse.de
Subject: Re: [PATCH]: jiffies wrap in ll_rw_blk.c
Date: Wed, 20 Nov 2002 16:06:59 -0500 [thread overview]
Message-ID: <20021120160659.D2854@redhat.com> (raw)
In-Reply-To: <3DDBF413.C06DAF2E@splentec.com>; from luben@splentec.com on Wed, Nov 20, 2002 at 03:44:03PM -0500
Erm, you just truncated a long to an int.
-ben
On Wed, Nov 20, 2002 at 03:44:03PM -0500, Luben Tuikov wrote:
> --- ll_rw_blk.c.old Wed Nov 20 15:32:50 2002
> +++ ll_rw_blk.c Wed Nov 20 15:33:06 2002
> @@ -2092,7 +2092,7 @@
> complete(req->waiting);
>
> if (disk) {
> - unsigned long duration = jiffies - req->start_time;
> + unsigned long duration = (signed) jiffies - (signed) req->start_time;
> switch (rq_data_dir(req)) {
> case WRITE:
> disk->writes++;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
"Do you seek knowledge in time travel?"
next prev parent reply other threads:[~2002-11-20 20:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-20 20:44 Luben Tuikov
2002-11-20 21:06 ` Benjamin LaHaise [this message]
2002-11-20 21:18 ` Luben Tuikov
2002-11-20 21:19 ` Alan Cox
2002-11-20 21:00 ` Luben Tuikov
2002-11-20 21:31 ` Alan Cox
2002-11-20 21:15 ` Luben Tuikov
2002-11-20 22:20 ` Olivier Galibert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021120160659.D2854@redhat.com \
--to=bcrl@redhat.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luben@splentec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®