mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "J.E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: "J.E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	john stultz <johnstul@us.ibm.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] [PATCH] subarch cleanup
Date: Fri, 22 Nov 2002 11:55:49 -0600	[thread overview]
Message-ID: <200211221755.gAMHtn703551@localhost.localdomain> (raw)
In-Reply-To: Message from "Martin J. Bligh" <mbligh@aracnet.com>  of "Fri, 22 Nov 2002 09:20:36 PST." <1053855634.1037956835@[10.10.2.3]>

mbligh@aracnet.com said:
> Duplicating all the code sections into all the subarches is an
> impractical maintainance nightmare. Yet that's how it seems to be set
> up at the moment (kind of OK if you only have 1 subarch apart from
> generic, but not in general). 

well, the way it works was modelled on the asm-arch to asm-generic setup (and 
we have currently twenty of those).

But still, I agree that a default fallback is a better way of doing it.

> If you have a different suggestion for fixing subarch support, please
> outline it .... 

Well, I think what Alan does in -ac6 is the correct approach (with 
mach-default fallback, not mach-generic, which is really PC specific).  The 
only difference between Alan and John's patches (apart from mach-default) is 
the _H _C split and the location of the header files.

I've no real objection to the _H _C split, other than it seems a bit 
contorted.  The intent I originally had was that all subarchs would have a 
small setup.c file (copied and modified from mach-generic), so I didn't 
envisage having a subarch which wanted to use the generic setup.c and a 
different _H directory.  Doing a _H _C split reduces simplicity.

As far as the location of _H.  All I'm really fishing for is a better reason 
than "because they're header files" basically because I believe interface 
containment has value.

James



  reply	other threads:[~2002-11-22 17:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-20  0:00 john stultz
2002-11-21 18:33 ` Sam Ravnborg
2002-11-21 18:35   ` Martin J. Bligh
2002-11-21 19:34     ` Russell King
2002-11-21 21:47       ` Martin J. Bligh
2002-11-22 15:00     ` J.E.J. Bottomley
2002-11-22 15:42       ` Martin J. Bligh
2002-11-22 16:40         ` J.E.J. Bottomley
2002-11-22 16:57           ` Christoph Hellwig
2002-11-22 17:20           ` Martin J. Bligh
2002-11-22 17:55             ` J.E.J. Bottomley [this message]
2002-11-21 18:55   ` john stultz
2002-11-21 19:15     ` Sam Ravnborg
2002-11-21 20:27       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200211221755.gAMHtn703551@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@aracnet.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®