From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 27 Nov 2002 17:39:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 27 Nov 2002 17:39:35 -0500 Received: from h-64-105-35-74.SNVACAID.covad.net ([64.105.35.74]:10120 "EHLO freya.yggdrasil.com") by vger.kernel.org with ESMTP id ; Wed, 27 Nov 2002 17:39:34 -0500 From: "Adam J. Richter" Date: Wed, 27 Nov 2002 14:44:24 -0800 Message-Id: <200211272244.OAA07729@baldur.yggdrasil.com> To: hch@infradead.org Subject: Re: Patch/resubmit(2.5.49): Use struct io_restrictions in blkdev.h Cc: axboe@suse.de, linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig wrote: >On Wed, Nov 27, 2002 at 12:59:46PM -0800, Adam J. Richter wrote: >> >On Wed, Nov 27, 2002 at 11:49:40AM -0800, Adam J. Richter wrote: >> >> Here is an updated version of the patch. The struct >> >> io_restrictions declaration is in so that the >> >> device-mapper user level utilities compile properly (device-mapper.h >> >> is written to support inclusion by user level programs). >> >> >They shouldn't include it anyway. Please put it into a proper place. >> >> I don't know what you mean by "shouldn't" or "proper" in this >> context. If you'd state technical advantages or disadvanges, others >> could determine these labels for themselves. >> >> Anyhow, what would be a "proper" place as you see it? >blkdev.h I expect struct io_restrictions to be useful beyond blkdev. I want to evolve it for use in DMA scatterlists in general, so blkdev.h could only be a temporary home. If you really want and nobody else objects, I'd be willing to create a separate .h file for struct io_restrictions. (I assume that what you find "improper" about device-mapper.h is that block devices themselves do not depend on any abstractions specific to the device mapper.) That would not break device-mapper, and you could take the less disruptive approach of submitting a patch to glibc and/or device-mapper to eliminate the user level program including kernel headers. Adam J. Richter __ ______________ 575 Oroville Road adam@yggdrasil.com \ / Milpitas, California 95035 +1 408 309-6081 | g g d r a s i l United States of America "Free Software For The Rest Of Us."