mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: "Wang, Stanley" <stanley.wang@intel.com>
Cc: "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] [2.5.49] symbol_get doesn't work
Date: Wed, 27 Nov 2002 10:27:33 +1100	[thread overview]
Message-ID: <20021127225227.746B12C0BD@lists.samba.org> (raw)
In-Reply-To: Your message of "Tue, 26 Nov 2002 16:14:29 +0800." <957BD1C2BF3CD411B6C500A0C944CA2601F11696@pdsmsx32.pd.intel.com>

In message <957BD1C2BF3CD411B6C500A0C944CA2601F11696@pdsmsx32.pd.intel.com> you
 write:
> Hello,
> I found the symbol_get()/symbol_put() didn't work on my 2.5.49 build.
> I think the root cause is a wrong macro definition. The following patch
> could 
> fix this bug.

Hi Wang,

	Thanks for the bug report, but I think you misunderstand.
symbol_get() does not take a string, it takes an identifier.  This
way, we can ensure the type is correct.  eg.

	/* In header somewhere. */
	extern int their_integer;

	....
		int *ptr = symbol_get(their_integer);
		if (!ptr) ...

Does that help?
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

  reply	other threads:[~2002-11-27 22:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-26  8:14 Wang, Stanley
2002-11-26 23:27 ` Rusty Russell [this message]
2002-11-27 23:19   ` Rusty Lynch
2002-11-28 23:42     ` Rusty Russell
2002-11-29  1:31       ` Miles Bader
2002-11-29  2:02         ` Sean Neakums
2002-11-29  2:11           ` Miles Bader
2002-11-29  3:29         ` Rusty Russell
2002-11-27  1:30 Wang, Stanley
2002-11-28  3:01 ` Rusty Russell
     [not found] <957BD1C2BF3CD411B6C500A0C944CA2601F116A1@pdsmsx32.pd.intel.com>
2002-11-29  0:01 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021127225227.746B12C0BD@lists.samba.org \
    --to=rusty@rustcorp.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stanley.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome