[TRIVIAL PATCH 2.5] Re: [2.5.50] uninitialized timer

[Lucio Maciel <abslucio@terra.com.br>]

[-- Attachment #1: Type: text/plain, Size: 2693 bytes --]


Fix a unitialized timer in drivers/video/fbcon.c

Its just a warning, try this patch
Try this patch


best regards
On Fri, 29 Nov 2002 18:58:16 +0100
Jochen Hein <jochen@jochen.org> wrote:

> 
> Booting 2.2.50 gives:
> 
> vesafb: framebuffer at 0xe0000000, mapped to 0xc680d000, size 1984k
> vesafb: mode is 1024x768x16, linelength=2048, pages=0
> vesafb: protected mode interface info at c000:8e10
> vesafb: scrolling: redraw
> vesafb: directcolor: size=0:5:6:5, shift=0:11:5:0
> Uninitialised timer!
> This is just a warning.  Your computer is OK
> function=0xc0249c20, data=0x0
> Call Trace: [<c011deb0>]  [<c0249c20>]  [<c011def7>]  [<c024a003>]
> [<c021855f>]  [<c0249409>]  [<c0105086>]  [<c0105058>]  [<c0106e6d>]
> Console: switching to colour frame buffer device 128x48
> 
> Passed through ksymoops I get:
> 
> ksymoops 2.4.6 on i686 2.5.50.  Options used
>      -V (default)
>      -k /proc/ksyms (default)
>      -l /proc/modules (default)
>      -o /lib/modules/2.5.50/ (default)
>      -m /boot/System.map-2.5.50 (default)
> 
> Warning: You did not tell me where to find symbol information.  I will
> assume that the log matches the kernel and modules that are running
> right now and I'll use the default options above for symbol resolution.
> If the current kernel and/or modules do not match the log, you can get
> more accurate output by telling me the kernel version and where to find
> map, modules, ksyms etc.  ksymoops -h explains the options.
> 
> Error (regular_file): read_ksyms stat /proc/ksyms failed
> No modules in ksyms, skipping objects
> No ksyms, skipping lsmod
> Call Trace: [<c011deb0>]  [<c0249c20>]  [<c011def7>]  [<c024a003>]  [<c021855f>]  [<c0249409>]  [<c0105086>]  [<c0105058>]  [<c0106e6d>] 
> Warning (Oops_read): Code line not seen, dumping what data is available
> 
> 
> Trace; c011deb0 <check_timer_failed+40/4c>
> Trace; c0249c20 <cursor_timer_handler+0/28>
> Trace; c011def7 <add_timer+3b/120>
> Trace; c024a003 <fbcon_startup+43/4c>
> Trace; c021855f <take_over_console+17/18c>
> Trace; c0249409 <register_framebuffer+181/1cc>
> Trace; c0105086 <init+2e/178>
> Trace; c0105058 <init+0/178>
> Trace; c0106e6d <kernel_thread_helper+5/c>
> 
> 2 warnings and 1 error issued.  Results may not be reliable.
> 
> Hope that helps.
> 
> Jochen
> 
> -- 
> Wenn Du nicht weißt was Du tust, tu's mit Eleganz.
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


-- 
::: Lucio F. Maciel
::: abslucio@terra.com.br
::: icq 93065464
::: Absoluta.net

[-- Attachment #2: fbcon.patch --]
[-- Type: application/octet-stream, Size: 331 bytes --]

--- linux/drivers/video/fbcon.c~	2002-11-28 09:58:30.000000000 -0200
+++ linux/drivers/video/fbcon.c	2002-11-29 16:55:36.000000000 -0200
@@ -458,6 +458,7 @@
 
     if (irqres) {
 	cursor_blink_rate = DEFAULT_CURSOR_BLINK_RATE;
+	init_timer(&cursor_timer);
 	cursor_timer.expires = jiffies+HZ/50;
 	add_timer(&cursor_timer);
     }