From: Matt Reppert <arashi@arashi.yi.org>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Unsafe MODULE_ usage in crc32.c
Date: Sat, 30 Nov 2002 18:12:24 -0600 [thread overview]
Message-ID: <20021130181224.4b4cddad.arashi@arashi.yi.org> (raw)
Hi,
Okay, I know, it's just a library module, doesn't need to ever be unloaded
anyway. But error noise in dmesg annoys me, hence this patch.
Matt
Convert CRC32 to try_module_get; fixes an unsafe usage that
prevents unloading.
lib/crc32.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletion(-)
--- linux-2.5.50/lib/crc32.c~crc32-unsafe 2002-11-30 05:31:19.000000000 -0600
+++ linux-2.5.50-arashi/lib/crc32.c 2002-11-30 05:36:17.000000000 -0600
@@ -551,7 +551,10 @@ static int __init init_crc32(void)
rc1 = crc32init_le();
rc2 = crc32init_be();
rc = rc1 || rc2;
- if (!rc) MOD_INC_USE_COUNT;
+ if (!rc) {
+ if (!try_module_get(THIS_MODULE))
+ rc = -1;
+ }
return rc;
}
[patch ends]
next reply other threads:[~2002-12-01 0:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-01 0:12 Matt Reppert [this message]
2002-12-01 0:25 ` Petr Vandrovec
2002-12-02 13:31 ` Arnd Bergmann
2002-12-02 16:08 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021130181224.4b4cddad.arashi@arashi.yi.org \
--to=arashi@arashi.yi.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome