From: Herbert Xu <herbert@gondor.apana.org.au>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.4 double PCI unregistration with pcigame
Date: Sun, 1 Dec 2002 21:45:02 +1100 [thread overview]
Message-ID: <20021201104502.GA19773@gondor.apana.org.au> (raw)
In-Reply-To: <20021201110808.B14392@ucw.cz>
On Sun, Dec 01, 2002 at 11:08:08AM +0100, Vojtech Pavlik wrote:
>
> I think the proper solution would be:
This wouldn't work since trident.o requires pcigame.o to work even
though the latter may not discover any devices on its own. That's
why that comment is there.
> diff -u -r1.1.1.7 pcigame.c
> --- drivers/char/joystick/pcigame.c 28 Nov 2002 23:53:12 -0000 1.1.1.7
> +++ drivers/char/joystick/pcigame.c 1 Dec 2002 02:32:08 -0000
>
> @@ -195,7 +195,7 @@
>
> int __init pcigame_init(void)
> {
> - pci_module_init(&pcigame_driver);
> - /* Needed by other modules */
> - return 0;
> + return pci_module_init(&pcigame_driver);
> }
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2002-12-01 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-01 4:40 Herbert Xu
2002-12-01 10:08 ` Vojtech Pavlik
2002-12-01 10:45 ` Herbert Xu [this message]
2002-12-01 10:49 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021201104502.GA19773@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®