From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
To: Marcelo Tosatti <marcelo@conectiva.com.br>,
Jeff Garzik <jgarzik@mandrakesoft.com>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
irda-users@lists.sourceforge.net
Subject: [PATCH 2.4] : ir241_smc_msg.diff
Date: Mon, 2 Dec 2002 15:40:17 -0800 [thread overview]
Message-ID: <20021202234017.GG16284@bougret.hpl.hp.com> (raw)
ir241_smc_msg.diff :
------------------
<Following patch from Jeff Snyder>
o [CRITICA] Release the proper region and not NULL pointer
o [FEATURE] Fix messages
diff -u -p linux/drivers/net/irda/smc-ircc.d8.c linux/drivers/net/irda/smc-ircc.c
--- linux/drivers/net/irda/smc-ircc.d8.c Tue Aug 6 18:12:05 2002
+++ linux/drivers/net/irda/smc-ircc.c Tue Aug 6 18:14:08 2002
@@ -10,6 +10,8 @@
* Modified by: Dag Brattli <dag@brattli.net>
* Modified at: Tue Jun 26 2001
* Modified by: Stefani Seibold <stefani@seibold.net>
+ * Modified at: Thur Apr 18 2002
+ * Modified by: Jeff Snyder <je4d@pobox.com>
*
* Copyright (c) 2001 Stefani Seibold
* Copyright (c) 1999-2001 Dag Brattli
@@ -537,7 +539,7 @@ static int __init ircc_open(unsigned int
if (ircc_irq < 255) {
if (ircc_irq!=irq)
MESSAGE("%s, Overriding IRQ - chip says %d, using %d\n",
- driver_name, self->io->irq, ircc_irq);
+ driver_name, irq, ircc_irq);
self->io->irq = ircc_irq;
}
else
@@ -545,13 +547,13 @@ static int __init ircc_open(unsigned int
if (ircc_dma < 255) {
if (ircc_dma!=dma)
MESSAGE("%s, Overriding DMA - chip says %d, using %d\n",
- driver_name, self->io->dma, ircc_dma);
+ driver_name, dma, ircc_dma);
self->io->dma = ircc_dma;
}
else
self->io->dma = dma;
- request_region(fir_base, CHIP_IO_EXTENT, driver_name);
+ request_region(self->io->fir_base, CHIP_IO_EXTENT, driver_name);
/* Initialize QoS for this device */
irda_init_max_qos_capabilies(&irport->qos);
@@ -1187,10 +1189,9 @@ static int __exit ircc_close(struct ircc
outb(IRCC_CFGB_IR, iobase+IRCC_SCE_CFGB);
#endif
/* Release the PORT that this driver is using */
- IRDA_DEBUG(0, "%s(), releasing 0x%03x\n",
- __FUNCTION__, self->io->fir_base);
+ IRDA_DEBUG(0, "%s(), releasing 0x%03x\n", __FUNCTION__, iobase);
- release_region(self->io->fir_base, self->io->fir_ext);
+ release_region(iobase, CHIP_IO_EXTENT);
if (self->tx_buff.head)
kfree(self->tx_buff.head);
reply other threads:[~2002-12-02 23:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021202234017.GG16284@bougret.hpl.hp.com \
--to=jt@bougret.hpl.hp.com \
--cc=irda-users@lists.sourceforge.net \
--cc=jgarzik@mandrakesoft.com \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®