[TRIVIAL PATCH 2.5] Uninitialised timer in matroxfb_DAC1064 [Was] Re: What does that mean (2.5.50)?

[Lucio Maciel <abslucio@terra.com.br>]

[-- Attachment #1: Type: text/plain, Size: 1808 bytes --]


Fix an Uninitialised timer in matroxfb_DAC1064.c

best regards
On Mon, 2 Dec 2002 22:33:35 +0100
Gregoire Favre <greg@ulima.unil.ch> wrote:

> On Mon, Dec 02, 2002 at 10:24:21PM +0100, Gregoire Favre wrote:
> 
> > matroxfb: framebuffer at 0xDC000000, mapped to 0xe0805000, size 33554432
> > Uninitialised timer!
> > This is just a warning.  Your computer is OK
> > function=0xc02a654c, data=0x0
> > Call Trace:
> >  [<c0123e7f>] check_timer_failed+0x63/0x65
> >  [<c02a654c>] cursor_timer_handler+0x0/0x3c
> >  [<c0123ec0>] add_timer+0x3f/0xa1
> >  [<c02a68fa>] fbcon_startup+0x4b/0x4d
> >  [<c023c400>] take_over_console+0x29/0x1c8
> >  [<c02a5be8>] register_framebuffer+0xe9/0x16d
> >  [<c02ad111>] initMatrox2+0x849/0xaba
> >  [<c02ad810>] matroxfb_probe+0x286/0x2da
> >  [<c021e80a>] pci_device_probe+0x5e/0x6c
> >  [<c0227746>] bus_match+0x45/0x7d
> >  [<c0227847>] driver_attach+0x51/0x69
> >  [<c0227b13>] bus_add_driver+0xa7/0xcd
> >  [<c0227ef5>] driver_register+0x2f/0x33
> >  [<c01703c5>] create_proc_entry+0x88/0xbc
> >  [<c021e922>] pci_register_driver+0x47/0x57
> >  [<c010506e>] init+0x3d/0x15a
> >  [<c0105031>] init+0x0/0x15a
> >  [<c0107079>] kernel_thread_helper+0x5/0xb
> > 
> > Console: switching to colour frame buffer device 200x75
> 
> Is the principal question...
> 
> Thank you very much,
> 
> 	Grégoire
> ________________________________________________________________
> http://ulima.unil.ch/greg ICQ:16624071 mailto:greg@ulima.unil.ch
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


-- 
::: Lucio F. Maciel
::: abslucio@terra.com.br
::: icq 93065464
::: Absoluta.net

[-- Attachment #2: matroxfb_DAC1064.patch --]
[-- Type: application/octet-stream, Size: 583 bytes --]

--- linux-2.5.50/drivers/video/matrox/matroxfb_DAC1064.c~	2002-11-22 19:40:41.000000000 -0200
+++ linux-2.5.50/drivers/video/matrox/matroxfb_DAC1064.c	2002-12-03 09:18:10.000000000 -0200
@@ -41,6 +41,7 @@
 #define minfo ((struct matrox_fb_info*)ptr)
 	matroxfb_DAC_lock_irqsave(flags);
 	outDAC1064(PMINFO M1064_XCURCTRL, inDAC1064(PMINFO M1064_XCURCTRL) ^ M1064_XCURCTRL_DIS ^ M1064_XCURCTRL_XGA);
+	init_timer(&ACCESS_FBINFO(cursor.timer));
 	ACCESS_FBINFO(cursor.timer.expires) = jiffies + HZ/2;
 	add_timer(&ACCESS_FBINFO(cursor.timer));
 	matroxfb_DAC_unlock_irqrestore(flags);