mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Mark Haverkamp <markh@osdl.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] aacraid 2.5
Date: Sat, 7 Dec 2002 00:30:11 +0000	[thread overview]
Message-ID: <20021207003011.A21628@infradead.org> (raw)
In-Reply-To: <1039189541.6401.8.camel@markh1.pdx.osdl.net>; from markh@osdl.org on Fri, Dec 06, 2002 at 07:45:42AM -0800

On Fri, Dec 06, 2002 at 07:45:42AM -0800, Mark Haverkamp wrote:
> +/**
> + * 	Convert capacity to cylinders
> + *  	accounting for the fact capacity could be a 64 bit value
> + *
> + */
> +static inline u32 cap_to_cyls(sector_t capacity, u32 divisor)
> +{
> +#ifdef CONFIG_LBD
> +	do_div(capacity, divisor);
> +#else
> +	capacity /= divisor;
> +#endif
> +	return (u32) capacity;
> +}

Please use sector_div() instead.  It exists for a reason.


  reply	other threads:[~2002-12-07  0:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-06 15:45 Mark Haverkamp
2002-12-07  0:30 ` Christoph Hellwig [this message]
2002-12-09 18:55   ` Mark Haverkamp
     [not found] <158487460@toto.iv>
2002-12-09 22:02 ` Peter Chubb
2002-12-09 23:13   ` Mark Haverkamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021207003011.A21628@infradead.org \
    --to=hch@infradead.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markh@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome