From: Bjorn Helgaas <bjorn_helgaas@hp.com>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Fix CPU bitmask truncation
Date: Mon, 16 Dec 2002 12:13:29 -0700 [thread overview]
Message-ID: <200212161213.29230.bjorn_helgaas@hp.com> (raw)
This patch fixes some obviously incorrect bitmask truncations in 2.4.20.
diff -Nru a/include/linux/sched.h b/include/linux/sched.h
--- a/include/linux/sched.h Mon Dec 16 11:58:42 2002
+++ b/include/linux/sched.h Mon Dec 16 11:58:42 2002
@@ -482,8 +482,8 @@
policy: SCHED_OTHER, \
mm: NULL, \
active_mm: &init_mm, \
- cpus_runnable: -1, \
- cpus_allowed: -1, \
+ cpus_runnable: ~0UL, \
+ cpus_allowed: ~0UL, \
run_list: LIST_HEAD_INIT(tsk.run_list), \
next_task: &tsk, \
prev_task: &tsk, \
diff -Nru a/kernel/sched.c b/kernel/sched.c
--- a/kernel/sched.c Mon Dec 16 11:58:42 2002
+++ b/kernel/sched.c Mon Dec 16 11:58:42 2002
@@ -116,7 +116,7 @@
#define idle_task(cpu) (init_tasks[cpu_number_map(cpu)])
#define can_schedule(p,cpu) \
- ((p)->cpus_runnable & (p)->cpus_allowed & (1 << cpu))
+ ((p)->cpus_runnable & (p)->cpus_allowed & (1UL << cpu))
#else
@@ -359,7 +359,7 @@
if (task_on_runqueue(p))
goto out;
add_to_runqueue(p);
- if (!synchronous || !(p->cpus_allowed & (1 << smp_processor_id())))
+ if (!synchronous || !(p->cpus_allowed & (1UL << smp_processor_id())))
reschedule_idle(p);
success = 1;
out:
next reply other threads:[~2002-12-16 19:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-16 19:13 Bjorn Helgaas [this message]
2002-12-20 10:30 ` William Lee Irwin III
2002-12-20 11:15 ` William Lee Irwin III
2002-12-20 17:00 ` Bjorn Helgaas
2002-12-25 21:43 ` Alan Cox
2002-12-25 21:54 ` Linus Torvalds
2002-12-20 12:17 ` Andreas Schwab
2002-12-20 17:12 ` William Lee Irwin III
2002-12-20 18:23 ` Jeremy Fitzhardinge
2002-12-20 20:00 ` Andreas Schwab
2002-12-20 22:57 ` Anton Blanchard
2002-12-20 23:36 ` William Lee Irwin III
2002-12-20 23:42 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200212161213.29230.bjorn_helgaas@hp.com \
--to=bjorn_helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®