mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: jgarzik@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: Patch for e100 on my z505je
Date: Fri, 20 Dec 2002 03:32:58 -0500	[thread overview]
Message-ID: <20021220033258.A771@devserv.devel.redhat.com> (raw)

Jeff,

I tried Marcelo's 2.4.21-pre2 and the driver fails the self-test,
then dies in an unserviced interrupt storm. An obvious patch
seems to fix the problem here.

Amazingly enough, the driver works in RH 2.4.18-14 (e100 2.1.6-k1),
but if I take the same 2.1.6-k1 and implant it into Marcelo tree,
everything dies as before. Something is fishy here.

-- Pete

diff -urN -X dontdiff linux-2.4.21-pre2/drivers/net/e100/e100_main.c linux-2.4.21-pre2-usb/drivers/net/e100/e100_main.c
--- linux-2.4.21-pre2/drivers/net/e100/e100_main.c	2002-12-19 19:50:58.000000000 -0800
+++ linux-2.4.21-pre2-usb/drivers/net/e100/e100_main.c	2002-12-20 00:07:36.000000000 -0800
@@ -2288,6 +2288,8 @@
 
 	/* initialize the nic state before running test */
 	e100_sw_reset(bdp, PORT_SOFTWARE_RESET);
+	e100_dis_intr(bdp);
+
 	/* Setup the address of the self_test area */
 	selftest_cmd = bdp->selftest_phys;
 
@@ -2302,9 +2304,9 @@
 	writel(selftest_cmd, &bdp->scb->scb_port);
 	readw(&(bdp->scb->scb_status));	/* flushes last write, read-safe */
 
-	/* Wait at least 10 milliseconds for the self-test to complete */
+	/* Wait at least 20 milliseconds for the self-test to complete */
 	set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(HZ / 100 + 1);
+	schedule_timeout(HZ / 50 + 1);
 
 	/* disable interrupts since the're now enabled */
 	e100_dis_intr(bdp);

                 reply	other threads:[~2002-12-20  8:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021220033258.A771@devserv.devel.redhat.com \
    --to=zaitcev@redhat.com \
    --cc=jgarzik@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome