On Fri, Dec 20, 2002 at 12:41:37PM +0000, Dave Jones wrote:
> Linus,
>  Please pull from bk://linux-dj.bkbits.net/agpgart to get at the
> following fixes..
[snip]
> GNU diff for those who care (against Linus' bk tree) is at
> ftp.kernel.org/pub/linux/kernel/people/davej/patches/2.5/2.5.52/agpgart-fixes-1.diff

I'm using bk7 which contains all your patch except via* stuff which I'm
not interested in.
Agpgart and sis-agp compiled as modules. Modprobe agpgart succeeds, 
modprobe sis-agp oopses:

agpgart: Detected SiS 735 chipset
Unable to handle kernel paging request at virtual address 1f000207
 printing eip:
e085400c
*pde = 00000000
Oops: 0000
CPU:    0
EIP:    0060:[<e085400c>]    Not tainted
EFLAGS: 00010282
EIP is at 0xe085400c
eax: c15f5c80   ebx: 000000c0   ecx: 00000000   edx: 1f000207
esi: 00000000   edi: 00000000   ebp: e0992408   esp: df9c7ec4
ds: 0068   es: 0068   ss: 0068
Process modprobe (pid: 498, threadinfo=df9c6000 task=dd0bb900)
Stack: e08720c8 df9c7ee4 00000246 c15df740 000000c0 c15f5c00 00000000 e08722d0 
       c15f5c00 000000c0 c15f5c00 000000c0 e099424a c15f5c00 00000000 000000c4 
       e0875090 c15f5c00 e09923e0 c02391fe c15f5c00 e09943c0 c15f5c4c e0992408 
Call Trace:
 [<e08720c8>] agp_backend_initialize+0x18/0x190 [agpgart]
 [<e08722d0>] agp_register_driver+0x20/0xc0 [agpgart]
 [<e099424a>] agp_sis_probe+0x7a/0x90 [sis_agp]
 [<e0875090>] +0x30/0xa8 [agpgart]
 [<e09923e0>] agp_sis_pci_driver+0x0/0xa0 [sis_agp]
 [<c02391fe>] pci_device_probe+0x5e/0x70
 [<e09943c0>] agp_sis_pci_table+0x0/0x38 [sis_agp]
 [<e0992408>] agp_sis_pci_driver+0x28/0xa0 [sis_agp]
 [<c0273f05>] bus_match+0x45/0x80
 [<e0992408>] agp_sis_pci_driver+0x28/0xa0 [sis_agp]
 [<c027401e>] driver_attach+0x5e/0x80
 [<e0992408>] agp_sis_pci_driver+0x28/0xa0 [sis_agp]
 [<e0992424>] agp_sis_pci_driver+0x44/0xa0 [sis_agp]
 [<e0992408>] agp_sis_pci_driver+0x28/0xa0 [sis_agp]
 [<c0274317>] bus_add_driver+0xa7/0xd0
 [<e0992408>] agp_sis_pci_driver+0x28/0xa0 [sis_agp]
 [<e0992424>] agp_sis_pci_driver+0x44/0xa0 [sis_agp]
 [<c027479f>] driver_register+0x2f/0x40
 [<e0992408>] agp_sis_pci_driver+0x28/0xa0 [sis_agp]
 [<c0239337>] pci_register_driver+0x47/0x60
 [<e0992408>] agp_sis_pci_driver+0x28/0xa0 [sis_agp]
 [<e0994273>] agp_sis_init+0x13/0x60 [sis_agp]
 [<e09923e0>] agp_sis_pci_driver+0x0/0xa0 [sis_agp]
 [<c012f500>] sys_init_module+0x1b0/0x1d0
 [<c010af0b>] syscall_call+0x7/0xb

Code: 69 32 63 5f 63 6f 72 65 00 00 00 00 00 00 00 00 00 00 00 00 

If it matters, the compiler is:
bear:~# gcc-3.2 -v
Reading specs from /usr/lib/gcc-lib/i386-linux/3.2.2/specs
Configured with: ../src/configure -v --enable-languages=c,c++,java,f77,proto,pascal,objc,ada --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-gxx-include-dir=/usr/include/c++/3.2 --enable-shared --with-system-zlib --enable-nls --without-included-gettext --enable-__cxa_atexit --enable-clocale=gnu --enable-java-gc=boehm --enable-objc-gc i386-linux
Thread model: posix
gcc version 3.2.2 20021212 (Debian prerelease)

Cheers,
florin
-- 

"If it's not broken, let's fix it till it is."