mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Tim Pepper" <tpepper@vato.org>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: Alan Cox <alan@redhat.com>, linux-kernel@vger.kernel.org
Subject: ext3/jbd breaks md stacking in 2.4
Date: Mon, 23 Dec 2002 03:58:16 -0800	[thread overview]
Message-ID: <20021223035816.B9669@jose.vato.org> (raw)

I recently noticed that ext3/jbd break md stacking by making invalid
assumptions about the buffer head's b_private pointer.  There is a
thread discussing this on the LVM mailing list at:

http://linux.msede.com/lvm_mlist/archive/2002/07/0028.html

Searching google and driver source it seems to me that as others have
noticed this they've worked around it by keeping their own pools of
buffer heads instead of simply stacking on the system buffer head.
This strikes me as inefficient and just plain ugly.

The ability to stack b_rdev, b_private and b_end_io is documented kernel
behaviour and therefore shouldn't break in 2.4.

The above link in particular is to a simple patch Andrew Morton suggested.
This patch has been in -ac for quite a while, but is listed as not
forwarded to Marcello (any reason Alan?).  Is there any chance of getting
this fix into mainline kernels?

Tim

-- 
*********************************************************
*  tpepper@vato dot org             * Venimus, Vidimus, *
*  http://www.vato.org/~tpepper     * Dolavimus         *
*********************************************************

                 reply	other threads:[~2002-12-23 11:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021223035816.B9669@jose.vato.org \
    --to=tpepper@vato.org \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®