From: Rusty Russell <rusty@rustcorp.com.au>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org, rth@twiddle.net, trivial@rustcorp.com.au
Subject: [PATCH] Trivial patch for module.c: Strtab by sh_link field.
Date: Fri, 27 Dec 2002 21:23:11 +1100 [thread overview]
Message-ID: <20021227104328.079A62C052@lists.samba.org> (raw)
[ This is Richard being nitpicky, but it's worth keeping him happy 8) ]
Name: Strtab by sh_link field.
From: Richard Henderson <rth@twiddle.net>
Status: Trivial
D: The strtab section is supposed to be found using the symtab's
D: sh_link field, not by name.
===== kernel/module.c 1.32 vs edited =====
--- 1.32/kernel/module.c Thu Dec 19 18:19:53 2002
+++ edited/kernel/module.c Thu Dec 26 12:44:00 2002
@@ -1010,6 +979,9 @@
/* Internal symbols */
DEBUGP("Symbol table in section %u\n", i);
symindex = i;
+ /* Strings */
+ strindex = sechdrs[i].sh_link;
+ DEBUGP("String table found in section %u\n", strindex);
} else if (strcmp(secstrings+sechdrs[i].sh_name,
".gnu.linkonce.modname") == 0) {
/* This module's name */
@@ -1024,11 +1000,6 @@
/* Exported symbols. */
DEBUGP("EXPORT table in section %u\n", i);
exportindex = i;
- } else if (strcmp(secstrings + sechdrs[i].sh_name, ".strtab")
- == 0) {
- /* Strings */
- DEBUGP("String table found in section %u\n", i);
- strindex = i;
} else if (strcmp(secstrings+sechdrs[i].sh_name, "__param")
== 0) {
/* Setup parameter info */
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
reply other threads:[~2002-12-27 10:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021227104328.079A62C052@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@twiddle.net \
--cc=torvalds@transmeta.com \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®