mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kevin Corry <corry@ecn.purdue.edu>
To: joe@fib011235813.fsnet.co.uk (Joe Thornber)
Cc: dm-devel@sistina.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dm.c : Check memory allocations
Date: Tue, 31 Dec 2002 11:22:28 -0500 (EST)	[thread overview]
Message-ID: <200212311622.gBVGMS5R028448@shay.ecn.purdue.edu> (raw)
In-Reply-To: <20021230105114.GB2703@reti> from "Joe Thornber" at Dec 30, 2002 10:51:14 AM

> 
> On Fri, Dec 27, 2002 at 04:55:31PM -0500, Kevin Corry wrote:
> > Check memory allocations when cloning bio's.
> 
> Rejected, clone_bio() cannot fail since it's allocating from a mempool
> with __GFP_WAIT set.
> 
> - Joe

Hmm. Yep. I must have mistaken GFP_NOIO for GFP_ATOMIC.

But based on that reasoning, shouldn't the bio_alloc() call
in split_bvec() always return a valid bio, and hence make the
checks in split_bvec() and __clone_and_map() unnecessary?

Kevin


  reply	other threads:[~2002-12-31 16:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-27 21:55 Kevin Corry
2002-12-27 22:00 ` Jeff Garzik
2002-12-27 22:16   ` Kevin Corry
2002-12-30 10:51 ` Joe Thornber
2002-12-31 16:22   ` Kevin Corry [this message]
2003-01-02  9:55     ` Joe Thornber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200212311622.gBVGMS5R028448@shay.ecn.purdue.edu \
    --to=corry@ecn.purdue.edu \
    --cc=dm-devel@sistina.com \
    --cc=joe@fib011235813.fsnet.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®