From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
To: Jeff Garzik <jgarzik@mandrakesoft.com>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: [PATCH 2.5] : IrCOMM status init fixes
Date: Wed, 8 Jan 2003 18:55:20 -0800 [thread overview]
Message-ID: <20030109025520.GF19178@bougret.hpl.hp.com> (raw)
ir254_ircomm_dce.diff :
---------------------
<Patch from Jan Kiszka>
o [CORRECT] Properly initialise IrCOMM status line (DCE settings)
diff -u -p linux/net/irda/ircomm/ircomm_param.d5.c linux/net/irda/ircomm/ircomm_param.c
--- linux/net/irda/ircomm/ircomm_param.d5.c Wed Jan 8 17:40:08 2003
+++ linux/net/irda/ircomm/ircomm_param.c Wed Jan 8 17:51:19 2003
@@ -442,7 +442,9 @@ static int ircomm_param_dte(void *instan
param->pv.i = self->settings.dte;
else {
dte = (__u8) param->pv.i;
-
+
+ self->settings.dce = 0;
+
if (dte & IRCOMM_DELTA_DTR)
self->settings.dce |= (IRCOMM_DELTA_DSR|
IRCOMM_DELTA_RI |
diff -u -p linux/net/irda/ircomm/ircomm_tty.d5.c linux/net/irda/ircomm/ircomm_tty.c
--- linux/net/irda/ircomm/ircomm_tty.d5.c Wed Jan 8 17:40:17 2003
+++ linux/net/irda/ircomm/ircomm_tty.c Wed Jan 8 17:53:22 2003
@@ -490,7 +490,8 @@ static int ircomm_tty_open(struct tty_st
if (line < 0x10) {
self->service_type = IRCOMM_3_WIRE | IRCOMM_9_WIRE;
self->settings.service_type = IRCOMM_9_WIRE; /* 9 wire as default */
- self->settings.dce = IRCOMM_CTS | IRCOMM_CD; /* Default line settings */
+ /* Jan Kiszka -> add DSR/RI -> Conform to IrCOMM spec */
+ self->settings.dce = IRCOMM_CTS | IRCOMM_CD | IRCOMM_DSR | IRCOMM_RI; /* Default line settings */
IRDA_DEBUG(2, "%s(), IrCOMM device\n", __FUNCTION__ );
} else {
IRDA_DEBUG(2, "%s(), IrLPT device\n", __FUNCTION__ );
reply other threads:[~2003-01-09 2:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030109025520.GF19178@bougret.hpl.hp.com \
--to=jt@bougret.hpl.hp.com \
--cc=jgarzik@mandrakesoft.com \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®