From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
To: Miles Bader <miles@gnu.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix socket.c compilation failure when CONFIG_NET=n
Date: Thu, 9 Jan 2003 10:06:26 -0800 [thread overview]
Message-ID: <20030109180626.GA24023@bougret.hpl.hp.com> (raw)
In-Reply-To: <20030107064107.C19A73745@mcspd15.ucom.lsi.nec.co.jp>
On Tue, Jan 07, 2003 at 03:41:07PM +0900, Miles Bader wrote:
> [I send this to Linus earlier and he ignored it; maybe you're the right
> person...]
>
> In net/socket.c, <linux/wireless.h> is included twice, once conditionally
> (on CONFIG_NET_RADIO || CONFIG_NET_PCMCIA_RADIO) and once unconditionally.
> However, including <linux/wireless.h> defines WIRELESS_EXT, and this causes an
> #ifdef in `sock_ioctl' to reference `dev_ioctl', which isn't defined when
> CONFIG_NET=n, and so results in an unresolved symbol reference in that case.
>
> The following patch fixes this by removing the unconditional include, and only
> keeping the conditional one.
>
> Thanks,
>
> -Miles
>
> diff -ruN -X../cludes linux-2.5.54-moo.orig/net/socket.c linux-2.5.54-moo/net/socket.c
> --- linux-2.5.54-moo.orig/net/socket.c 2002-11-25 10:30:11.000000000 +0900
> +++ linux-2.5.54-moo/net/socket.c 2003-01-06 13:27:17.000000000 +0900
> @@ -75,7 +75,6 @@
> #include <linux/cache.h>
> #include <linux/module.h>
> #include <linux/highmem.h>
> -#include <linux/wireless.h>
> #include <linux/divert.h>
> #include <linux/mount.h>
This was included in 2.5.55, so I guess Linus didn't ignored you.
Regards,
Jean
next prev parent reply other threads:[~2003-01-09 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-07 6:41 Miles Bader
2003-01-09 18:06 ` Jean Tourrilhes [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-12-26 3:21 Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030109180626.GA24023@bougret.hpl.hp.com \
--to=jt@bougret.hpl.hp.com \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miles@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®