From: Matti Aarnio <matti.aarnio@zmailer.org>
To: Rudmer van Dijk <rudmer@legolas.dynup.net>
Cc: Paul Gortmaker <p_gortmaker@yahoo.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.55 fix etherleak in 8390.c [rescued]
Date: Fri, 10 Jan 2003 21:25:46 +0200 [thread overview]
Message-ID: <20030110192546.GI27709@mea-ext.zmailer.org> (raw)
In-Reply-To: <200301101835.h0AIZA704332@mail.intergenia.de>
On Fri, Jan 10, 2003 at 07:35:10PM +0100, Rudmer van Dijk wrote:
> this is the fix which went in 2.4.21-pre3-ac2, rediffed against 2.5.55
> Rudmer
That scratch[] allocation is 60 bytes, taken off the stack.
It isn't very large, and isn't recursive, but still...
> --- linux-2.5.55/drivers/net/8390.c.orig 2003-01-10 16:23:44.000000000 +0100
> +++ linux-2.5.55/drivers/net/8390.c 2003-01-10 16:23:00.000000000 +0100
> @@ -270,6 +270,7 @@
> struct ei_device *ei_local = (struct ei_device *) dev->priv;
> int length, send_length, output_page;
> unsigned long flags;
> + char scratch[ETH_ZLEN];
>
> length = skb->len;
/Matti Aarnio
prev parent reply other threads:[~2003-01-10 19:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-10 18:35 Rudmer van Dijk
2003-01-10 19:25 ` Matti Aarnio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030110192546.GI27709@mea-ext.zmailer.org \
--to=matti.aarnio@zmailer.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
--cc=rudmer@legolas.dynup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®