From: "Adam J. Richter" <adam@yggdrasil.com>
To: hch@lst.de, torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] umode_t changes from Adam's mini-devfs
Date: Sat, 11 Jan 2003 14:16:13 -0800 [thread overview]
Message-ID: <200301112216.OAA16593@baldur.yggdrasil.com> (raw)
Christoph Hellwig wrote:
>The use of umode_t instead of devfs-specific char vs block #defines
>in Adam's mini-devfs patch makes sense independant of whether his patch
>should get merged. While reviewing his changes I also notices that
>most of the number allocation functionality in devfs has no business
>beeing exported. In addition I cleaned up devfs_alloc_devnum/
>devfs_dealloc_devnum a bit.
It looks good to me, although I haven't tried it or fully
comprehended every line of Christoph's devfs_{,de}alloc_devnum cleanup
(I have looked at it a bit before sending this email though).
One really minor suggestion: perhaps Christoph could add an
entry in the giant change log in fs/devfs/util.c so that people know
who to contact if there is a problem with his number allocation
change.
Adam J. Richter __ ______________ 575 Oroville Road
adam@yggdrasil.com \ / Milpitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."
next reply other threads:[~2003-01-11 22:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-11 22:16 Adam J. Richter [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-01-15 20:17 Christoph Hellwig
2003-01-11 18:29 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200301112216.OAA16593@baldur.yggdrasil.com \
--to=adam@yggdrasil.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®