From: Rusty Trivial Russell <rusty@rustcorp.com.au>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [TRIVIAL] [2.5 patch] MODULE_FORCE_UNLOAD must depend on MODULE_UNLOAD (fwd)
Date: Tue, 14 Jan 2003 13:25:21 +1100 [thread overview]
Message-ID: <20030114025453.561EF2C43E@lists.samba.org> (raw)
From: Adrian Bunk <bunk@fs.tum.de>
Hi Linus,
the patch in the mail forwarded below is still needed in 2.5.56.
Rusty already stated that the patch is correct.
Please apply
Adrian
----- Forwarded message from Adrian Bunk <bunk@fs.tum.de> -----
Date: Wed, 8 Jan 2003 00:07:42 +0100
From: Adrian Bunk <bunk@fs.tum.de>
To: "Robert P. J. Day" <rpjday@mindspring.com>,
rusty@rustcorp.com.au,
Linus Torvalds <torvalds@transmeta.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: [2.5 patch] MODULE_FORCE_UNLOAD must depend on MODULE_UNLOAD
On Wed, Jan 01, 2003 at 02:55:01PM -0500, Robert P. J. Day wrote:
>...
> Loadable module support
>
> Does "Module unloading" mean whether or not I can run "rmmod"?
> And if I deselect this, why can I still select "Forced module
> unloading"? Either I can unload or I can't, no?
>...
Thanks for spotting this, after reading kernel/module.c it seems obvious
to me that you are right. The following simple patch fixes it:
--- trivial-2.5.57/init/Kconfig.orig 2003-01-14 12:11:56.000000000 +1100
+++ trivial-2.5.57/init/Kconfig 2003-01-14 12:11:56.000000000 +1100
@@ -156,7 +156,7 @@
config MODULE_FORCE_UNLOAD
bool "Forced module unloading"
- depends on MODULES && EXPERIMENTAL
+ depends on MODULE_UNLOAD && EXPERIMENTAL
help
This option allows you to force a module to unload, even if the
kernel believes it is unsafe: the kernel will remove the module
--
Don't blame me: the Monkey is driving
File: Adrian Bunk <bunk@fs.tum.de>: [2.5 patch] MODULE_FORCE_UNLOAD must depend on MODULE_UNLOAD (fwd)
reply other threads:[~2003-01-14 2:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030114025453.561EF2C43E@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®