From: Andrew Morton <akpm@digeo.com>
To: Ted Phelps <phelps@dstc.edu.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] counting bug in svc_tcp_recvfrom causes panic for TCP NFS
Date: Wed, 15 Jan 2003 15:28:44 -0800 [thread overview]
Message-ID: <20030115152844.6a66cd0f.akpm@digeo.com> (raw)
In-Reply-To: <200301152254.WAA19810@tereshkova.dstc.edu.au>
Ted Phelps <phelps@dstc.edu.au> wrote:
>
> Perhaps a better solution would be to change page_address() to be
> consistently be a function for all memory layouts.
Assuredly. How about this?
diff -puN include/linux/mm.h~page_address-fix include/linux/mm.h
--- 25/include/linux/mm.h~page_address-fix 2003-01-15 15:23:45.000000000 -0800
+++ 25-akpm/include/linux/mm.h 2003-01-15 15:25:40.000000000 -0800
@@ -296,9 +296,11 @@ static inline void set_page_zone(struct
page->flags |= zone_num << ZONE_SHIFT;
}
-#define lowmem_page_address(page) \
- __va( ( ((page) - page_zone(page)->zone_mem_map) \
- + page_zone(page)->zone_start_pfn) << PAGE_SHIFT)
+static inline void *lowmem_page_address(struct page *page)
+{
+ return __va(((page - page_zone(page)->zone_mem_map)
+ + page_zone(page)->zone_start_pfn) << PAGE_SHIFT);
+}
#if defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL)
#define HASHED_PAGE_VIRTUAL
_
next prev parent reply other threads:[~2003-01-15 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-15 22:54 Ted Phelps
2003-01-15 23:28 ` Andrew Morton [this message]
2003-01-16 0:51 ` Ted Phelps
2003-01-16 0:57 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030115152844.6a66cd0f.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phelps@dstc.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®