mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pete Clements <clem@clem.clem-digital.net>
To: mzyngier@freesurf.fr
Cc: linux-kernel@vger.kernel.org (linux-kernel)
Subject: Re: 2.5.59 fails compile 3c509.c
Date: Fri, 17 Jan 2003 12:56:58 -0500 (EST)	[thread overview]
Message-ID: <200301171756.MAA01256@clem.clem-digital.net> (raw)
In-Reply-To: <wrp3cnryhmv.fsf@hina.wild-wind.fr.eu.org> from Marc Zyngier at "Jan 17, 2003  3:29:12 pm"

Quoting Marc Zyngier
  > 
  > Could you please try the following patch ?
  > 
  > Thanks,
  > 
  >         M.
  > 
  > ===== drivers/net/3c509.c 1.30 vs edited =====
  > --- 1.30/drivers/net/3c509.c	Wed Jan 15 11:07:35 2003
  > +++ edited/drivers/net/3c509.c	Fri Jan 17 15:26:30 2003
  > @@ -319,16 +319,6 @@
  >  	dev->watchdog_timeo = TX_TIMEOUT;
  >  	dev->do_ioctl = netdev_ioctl;
  >  
  > -#ifdef CONFIG_PM
  > -	/* register power management */
  > -	lp->pmdev = pm_register(PM_ISA_DEV, card_idx, el3_pm_callback);
  > -	if (lp->pmdev) {
  > -		struct pm_dev *p;
  > -		p = lp->pmdev;
  > -		p->data = (struct net_device *)dev;
  > -	}
  > -#endif
  > -
  >  	return 0;
  >  }
  >  
  > @@ -598,6 +588,16 @@
  >  #endif
  >  	lp->mca_slot = mca_slot;
  >  
  > +#ifdef CONFIG_PM
  > +	/* register power management */
  > +	lp->pmdev = pm_register(PM_ISA_DEV, card_idx, el3_pm_callback);
  > +	if (lp->pmdev) {
  > +		struct pm_dev *p;
  > +		p = lp->pmdev;
  > +		p->data = (struct net_device *)dev;
  > +	}
  > +#endif
  > +
  >  	return el3_common_init (dev);
  >  }
  >  
  > @@ -1080,12 +1080,14 @@
  >  	free_irq(dev->irq, dev);
  >  	/* Switching back to window 0 disables the IRQ. */
  >  	EL3WINDOW(0);
  > +#ifdef CONFIG_EISA
  >  	if (!lp->edev) {
  >  	    /* But we explicitly zero the IRQ line select anyway. Don't do
  >  	     * it on EISA cards, it prevents the module from getting an
  >  	     * IRQ after unload+reload... */
  >  	    outw(0x0f00, ioaddr + WN0_IRQ);
  >  	}
  > +#endif
  >  
  >  	return 0;
  >  }
  > 
  > -- 
  > Places change, faces change. Life is so very strange.
  > 


Patch fixes the compile problem.
-- 
Pete Clements 
clem@clem.clem-digital.net

      reply	other threads:[~2003-01-17 17:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-17 13:49 Pete Clements
2003-01-17 14:29 ` Marc Zyngier
2003-01-17 17:56   ` Pete Clements [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200301171756.MAA01256@clem.clem-digital.net \
    --to=clem@clem.clem-digital.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mzyngier@freesurf.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®