From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: William Lee Irwin III <wli@holomorphy.com>,
linux-kernel@vger.kernel.org, Martin.Bligh@us.ibm.com,
akpm@zip.com.au
Subject: Re: pci_child_fixup()
Date: Mon, 20 Jan 2003 14:57:54 +0300 [thread overview]
Message-ID: <20030120145754.A912@jurassic.park.msu.ru> (raw)
In-Reply-To: <20030120035217.GE770@holomorphy.com>; from wli@holomorphy.com on Sun, Jan 19, 2003 at 07:52:17PM -0800
On Sun, Jan 19, 2003 at 07:52:17PM -0800, William Lee Irwin III wrote:
> child = pci_add_new_bus(bus, dev, 0);
> - child->primary = buses & 0xFF;
> - child->secondary = (buses >> 8) & 0xFF;
> - child->subordinate = (buses >> 16) & 0xFF;
> - child->number = child->secondary;
> + pci_child_fixup(bus, child, buses);
The "bus" argument seems to be redundant. Why not use "child->parent"
just filled in by pci_add_new_bus() instead?
Ivan.
next prev parent reply other threads:[~2003-01-20 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-20 3:52 pci_child_fixup() William Lee Irwin III
2003-01-20 11:57 ` Ivan Kokshaysky [this message]
2003-01-20 12:53 ` pci_child_fixup() William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030120145754.A912@jurassic.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=Martin.Bligh@us.ibm.com \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome