mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kevin Lawton <kevinlawton2001@yahoo.com>
To: linux-kernel@vger.kernel.org
Subject: EDD bug find: wrong #define is used to declare edd[] area.
Date: Mon, 20 Jan 2003 16:44:41 -0800 (PST)	[thread overview]
Message-ID: <20030121004441.39150.qmail@web80309.mail.yahoo.com> (raw)

It appears to me that the wrong #define is being used to declare the
size of the EDD (BIOS Enhanced Disk Drive Services) area of the setup
parameter page.  The following lines use 'EDDNR', but I believe they
meant to use 'EDDMAXNR':  (src @ 2.5.59)

  include/asm-i386/edd.h:line 168:

    extern struct edd_info edd[EDDNR];

  arch/i386/kernel/setup.c:line 477:

    struct edd_info edd[EDDNR];


For reference:

  include/asm-i386/edd.h:
  #define EDDNR 0x1e9           /* addr of number of edd_info structs at EDDBUF
  #define EDDMAXNR 6            /* number of edd_info structs starting at
EDDBUF  */

EDDNR is the offset in the parameter page, not the number of entries.
EDDMAXNR seems to be the literal to use.  I haven't tried this fix,
because I don't use it.  Just noticed it while digging through the source.

-Kevin Lawton

__________________________________________________
Do you Yahoo!?
New DSL Internet Access from SBC & Yahoo!
http://sbc.yahoo.com

             reply	other threads:[~2003-01-21  0:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-21  0:44 Kevin Lawton [this message]
     [not found] <20030121004610.45288.qmail@web80311.mail.yahoo.com>
2003-01-24  6:20 ` Matt Domsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030121004441.39150.qmail@web80309.mail.yahoo.com \
    --to=kevinlawton2001@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®