mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: bgoglin@ens-lyon.fr
Cc: linux-kernel@vger.kernel.org
Subject: Re: AH transformation broken since 2.5.56
Date: Fri, 24 Jan 2003 11:52:52 -0800 (PST)	[thread overview]
Message-ID: <20030124.115252.24531266.davem@redhat.com> (raw)
In-Reply-To: <20030124100530.GA32263@ens-lyon.fr>

   From: Brice Goglin <bgoglin@ens-lyon.fr>
   Date: Fri, 24 Jan 2003 11:05:30 +0100

   My problem was based on the fact that you can disable
   CONFIG_CRYPTO_HMAC by disabling CONFIG_CRYPTO. But this will not
   disable CONFIG_INET_AH.
   
   Shouldn't there be a fix in dependencies between CONFIG_CRYPTO
   and CONFIG_CRYPTO_HMAC, or between CONFIG_INET_AH and
   CONFIG_CRYPTO ?

If you override the defaults, the responsibility lands in your
hands to do the right thing.

The only facility we have right now is to choose the defaults
sensibly for you, and if you look at crypto/Kconfig we are
doing exactly that.  It checks there fore whether AH or ESP
have been enabled, and chooses a default based upon that.

Also, CRYPTO selection comes after the ipsec choices.  So the
only thing we can do is make decisions based upon whether
you've enabled AH or ESP not the other way around.

Whether there should be a way to FORCE config options on or off
(instead of controlling the default) to avoid situations like this is
a seperate topic.

  reply	other threads:[~2003-01-24 19:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-24 10:05 Brice Goglin
2003-01-24 19:52 ` David S. Miller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-01-22 13:31 Brice Goglin
2003-01-24  2:21 ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030124.115252.24531266.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=bgoglin@ens-lyon.fr \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome