From: romieu@fr.zoreil.com
To: Michael Still <mikal@stillhq.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch] Fix errors in aironet4500 driver (cli_sti_removal-004) (fwd)
Date: Fri, 24 Jan 2003 00:15:49 +0100 [thread overview]
Message-ID: <20030124001549.B28073@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <Pine.LNX.4.30.0301240708430.10063-100000@localhost.localdomain>; from mikal@stillhq.com on Fri, Jan 24, 2003 at 07:09:06AM +1100
Michael Still <mikal@stillhq.com> :
>
> I'm resending this in the hope of people applying it.
>
> #endif /* AIRONET4500_H */
> diff -Nur linux-2.5.55/drivers/net/aironet4500_card.c linux-2.5.55-cli_sti_removal-002/drivers/net/aironet4500_card.c
> --- linux-2.5.55/drivers/net/aironet4500_card.c Fri Jan 10 09:18:46 2003
> +++ linux-2.5.55-cli_sti_removal-002/drivers/net/aironet4500_card.c Thu Jan 9 22:24:11 2003
[...]
> @@ -406,18 +398,18 @@
>
> ((struct awc_private *)dev->priv)->bus = logdev;
>
> - cli();
> + spin_lock_irq(&aironet4500_lock);
> if ( awc_init(dev) ){
> printk("card not found at irq %x io %lx\n",dev->irq, dev->base_addr);
> if (card==0){
> - sti();
> + spin_unlock_irq(&aironet4500_lock);
> return -1;
> }
> - sti();
> + spin_unlock_irq(&aironet4500_lock);
It isn't pretty and awc4500_pnp_probe() leaks memory with this return
(hint: follow 'dev').
--
Ueimor
prev parent reply other threads:[~2003-01-23 23:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-23 20:09 Michael Still
2003-01-23 23:15 ` romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030124001549.B28073@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikal@stillhq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®