From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Martin Mares <mj@ucw.cz>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
geert@linux-m68k.org, Richard Henderson <rth@twiddle.net>,
"Wiedemeier, Jeff" <Jeff.Wiedemeier@hp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2.5] VGA IO on systems with multiple PCI IO domains
Date: Mon, 27 Jan 2003 13:40:10 +0300 [thread overview]
Message-ID: <20030127134010.C2569@jurassic.park.msu.ru> (raw)
In-Reply-To: <20030127094645.GD604@ucw.cz>; from mj@ucw.cz on Mon, Jan 27, 2003 at 10:46:45AM +0100
On Mon, Jan 27, 2003 at 10:46:45AM +0100, Martin Mares wrote:
> > What about some kind of ioport_remap() that would take a pci_bus and an
> > port range as arguments ? If pci_bus is NULL, that would match a
> > "legacy" ISA bus (non-PCI machine or default ISA bus for machines where
> > that makes sense).
> >
> > What do you think ?
>
> Looks good, but maybe we should use some other functions than iob() et al.
> to do I/O on the remapped addresses.
What about this (what we'd have on alpha):
int
legacy_ioport_remap(struct resource *res)
{
switch (res->start) {
case 0x3c0: /* VGA */
res->start += pci_vga_hose->io_space->start;
res->end += pci_vga_hose->io_space->start;
case ???
...
default:
return -ENODEV;
}
return request_resource(pci_vga_hose->io_space, res);
}
void
legacy_ioport_unmap(struct resource *res)
{
release_resource(res);
}
Then vgacon.c would be changed like this:
...
- request_resource(&ioport_resource, &vga_console_resource);
+ if (legacy_ioport_remap(&vga_console_resource) < 0)
+ goto failure;
...
And all in/out port calls would use respective resource.start+offset:
...
- outb_p(6, 0x3ce)
+ outb_p(6, vga_console_resource.start + 0xe);
No need for other special IO functions then.
Ivan.
next prev parent reply other threads:[~2003-01-27 10:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-26 15:13 Ivan Kokshaysky
2003-01-26 21:45 ` Martin Mares
2003-01-26 23:40 ` Benjamin Herrenschmidt
2003-01-27 9:46 ` Martin Mares
2003-01-27 10:40 ` Ivan Kokshaysky [this message]
2003-01-27 17:55 ` Benjamin Herrenschmidt
2003-01-27 22:17 ` Ivan Kokshaysky
2003-01-28 9:32 ` Geert Uytterhoeven
2003-01-28 10:24 ` Ivan Kokshaysky
2003-01-28 10:27 ` Geert Uytterhoeven
2003-01-28 10:40 ` Ivan Kokshaysky
2003-01-28 17:10 ` Ivan Kokshaysky
2003-01-28 17:23 ` Benjamin Herrenschmidt
2003-01-28 17:33 ` Ivan Kokshaysky
2003-01-29 16:06 ` Ivan Kokshaysky
2003-01-29 18:15 ` James Simmons
2003-02-05 11:12 ` Ivan Kokshaysky
2003-03-12 19:08 ` Jesse Barnes
2003-01-27 10:12 ` Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030127134010.C2569@jurassic.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=Jeff.Wiedemeier@hp.com \
--cc=benh@kernel.crashing.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mj@ucw.cz \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome